Fix interledger-packet::ErrorCode too lenient parsing #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oki, a few force pushes later, I think this is ready to go :) |
koivunej
commented
May 4, 2021
| use std::convert::TryFrom; | ||
|
|
||
| #[test] | ||
| fn fuzzed_0_non_utf8_error_code() { |
There was a problem hiding this comment.
Suggested change
| fn fuzzed_0_non_utf8_error_code() { | |
| fn fuzzed_0_non_ascii_error_code() { |
I'll handle this in the follow-up.
pradovic
approved these changes
May 5, 2021
the rfc says it's an IA5STRING but it's being expected to be any 3 bytes, which are later assumed to be UTF-8 (as IA5STRING would be) in the ErrorCode implementation. Signed-off-by: Joonas Koivunen <joonas.koivunen@gmail.com>
This is a breaking change since this modifies the signature of interledger_packet::ErrorCode::new. Signed-off-by: Joonas Koivunen <joonas.koivunen@gmail.com>
this modifies the existing behaviour so that Display and Debug formatters now escape if any control characters are present using str's Debug implementation. Signed-off-by: Joonas Koivunen <joonas.koivunen@gmail.com>
This was referenced May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this crash stashed away, which wasn't because of ErrorCode or parsing, but because of too strict fuzz_target. This PR fixes:
There's some churn related to the roundtrip test fn being added and removed, but I'll follow up with a better
fuzz/fuzz_targets/packet.rsafter this PR.Cc: #705