feat(backend): performance and caching poc #2954
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(backend): add create quote service metrics * feat: add getQuote traces
# Conflicts: # localenv/cloud-nine-wallet/dbinit.sql
# Conflicts: # localenv/telemetry/grafana/provisioning/dashboards/example.json # test/performance/scripts/create-outgoing-payments.js
# Conflicts: # test/performance/scripts/create-outgoing-payments.js
…ason' into bc/ww-performance-jason
This reverts commit 7be75f2.
github-actions
bot
added
type: tests
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
BlairCurrey
reviewed
Sep 11, 2024
| const incomingPayment = await IncomingPayment.query(deps.knex).get(options) | ||
| await deps.assetService.setOn(incomingPayment) | ||
| await deps.walletAddressService.setOn(incomingPayment) | ||
|
|
There was a problem hiding this comment.
just for documentation's sake (dont necessarily need to do it here), Radu had a good suggestion for how to do this better.
We could override the withGraphFetched method on the model instead of manually retrieving/setting asset, wallet etc. everywhere. Would take some parsing of the original arguments or maybe some new arg to specify what to get off the cache.
There was a problem hiding this comment.
I think doing explicitly is better, overriding withGraphFetched might be a bit too hidden/"magic". Probably long term solution is just doing something like repository pattern and abstracting over ORM/db access, with an ability to add caching in front as well
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
Checklist
fixes #number