feat: added createIncomingPayment functionality for GraphQL #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pkg: backend
wilsonianb
reviewed
Oct 3, 2022
There was a problem hiding this comment.
It doesn't necessarily have to be in this pr, but I think we also want to be able to create incoming payments at other Open Payments servers via the admin api:
#580 (comment)
packages/backend/src/graphql/resolvers/incoming_payment.test.ts
Outdated
Show resolved
Hide resolved
packages/backend/src/graphql/resolvers/incoming_payment.test.ts
Outdated
Show resolved
Hide resolved
packages/backend/src/graphql/resolvers/incoming_payment.test.ts
Outdated
Show resolved
Hide resolved
packages/backend/src/graphql/resolvers/incoming_payment.test.ts
Outdated
Show resolved
Hide resolved
packages/backend/src/graphql/resolvers/incoming_payment.test.ts
Outdated
Show resolved
Hide resolved
wilsonianb
reviewed
Oct 4, 2022
* fix: removed unnecessary reference to grantId * fix: made the expiresAt field nullable * test: added tests that test with/without incomingAmount and expiresAt
wilsonianb
reviewed
Oct 4, 2022
packages/backend/src/graphql/resolvers/incoming_payment.test.ts
Outdated
Show resolved
Hide resolved
packages/backend/src/graphql/resolvers/incoming_payment.test.ts
Outdated
Show resolved
Hide resolved
packages/backend/src/graphql/resolvers/incoming_payment.test.ts
Outdated
Show resolved
Hide resolved
fix: testing against input values directly instead of the created payment
wilsonianb
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
Checklist
fixes #number