Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): do not import (nonexistent) test code #691

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

wilsonianb
Copy link
Contributor

@wilsonianb wilsonianb commented Oct 25, 2022

Changes proposed in this pull request

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass

@github-actions github-actions bot added pkg: backend Changes in the backend package. type: source Changes business logic labels Oct 25, 2022
@wilsonianb wilsonianb marked this pull request as ready for review October 25, 2022 18:29
Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my openPaymentsClientService refactoring, I propose we don't use "incomingPaymentRoutes" and "connectionRoutes" at all as dependencies in this file, but "incomingPaymentService" and "connectionService" instead -> I feel like we shouldn't need to mock a context to fetch data within the service itself. Let me know what you think of that.

This makes sense for now to fix local development, however!

@wilsonianb wilsonianb merged commit bb0ed3c into main Oct 25, 2022
@wilsonianb wilsonianb deleted the bw-fix-mock-ctx branch October 25, 2022 19:59
@wilsonianb
Copy link
Contributor Author

In my openPaymentsClientService refactoring, I propose we don't use "incomingPaymentRoutes" and "connectionRoutes" at all as dependencies in this file, but "incomingPaymentService" and "connectionService" instead -> I feel like we shouldn't need to mock a context to fetch data within the service itself. Let me know what you think of that.

I've been wrestling with that for a while:

If we can figure out how to reuse the model to Open Payments response conversions used by the routes, it should be more tolerable than this context mocking I've introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: backend Changes in the backend package. type: source Changes business logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't import test code
2 participants