feat(commerce/backend): add pre-interaction checkout flow #723

raducristianpopa · 2023-09-08T09:34:58Z

Context

closes Add OP client #722
closes Add first phase of the checkout flow (pre-interaction) #726

Changes

raducristianpopa · 2023-09-11T05:28:21Z

packages/commerce/backend/src/config/env.ts

+  AUTH_SERVER: z.string().url().default('http://rafiki-auth:3006'),
+  PAYMENT_POINTER: z.string().default('http://rafiki-backend/shop'),
+  KEY_ID: z.string().default('8e5e109e-9ea8-44a0-9490-1792bf1e07cb'),
+  PRIVATE_KEY: z
+    .string()
+    .default(
+      'LS0tLS1CRUdJTiBQUklWQVRFIEtFWS0tLS0tCk1DNENBUUF3QlFZREsyVndCQ0lFSU9LemxweFR5c0xhbS94VWZ5R2t2T2dpSmcraTEvT25STURWMElqNi9vVnQKLS0tLS1FTkQgUFJJVkFURSBLRVktLS0tLQ=='
+    )


We will need to seed our wallet with a default account with two payment pointers. Will do this in a separate PR later on.

why 2 payment pointers?

One that will be the shop's payment pointer and one that will act as the customer.

I don't think the customer one is necessary as any payment pointer can be used for customer actions

raducristianpopa · 2023-09-11T05:30:26Z

packages/commerce/backend/src/open-payments/service.ts

+          start: ['redirect'],
+          finish: {
+            method: 'redirect',
+            uri: `${this.env.FRONTEND_URL}/placeholder?orderId=${orderId}`,


Placeholder URL for the moment.

.gitignore

beniaminmunteanu · 2023-09-11T07:46:44Z

packages/commerce/backend/src/cache/in-memory.ts

+      return null
+    }
+
+    if (cached.expires !== null && cached.expires < Date.now()) {


Since this is a base cache class and might be used in other places as well directly as an abstraction, do you intend to also cleanup the cache on different instances except for when the specific item is retrieved and found as expired?

How about we also have a loop that periodically checks expired items? (Unless we want to have a notion of observability on cache misses which i don't think is the case)

What do you think about either a loop that checks expired items, or an implementation of an LRU cache?

I don't see how an LRU cache fits our case? Regarding the loop that periodically checks expired items, that's what I'm planning to do (we cache some order related fields so we won't need to save them in the database), but this is going to be in the second phase of the checkout flow (post-interaction).

packages/commerce/backend/src/open-payments/service.ts

packages/commerce/backend/src/cache/token.ts

packages/commerce/backend/src/open-payments/service.ts

* chore(deps): update typescript-eslint monorepo to ^6.6.0 (#714) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @tailwindcss/typography to ^0.5.10 (#715) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update pnpm to v8.7.4 (#716) * chore(deps): update pnpm to v8.7.4 * Update docker files --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Radu-Cristian Popa <radu.popa@breakpointit.eu> * fix(deps): update dependency ky to ^1.0.1 (#717) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(backend): Slow incoming payments (#706) * reduce expiry time to 15 sec on payment pointer transaction * Handle transfer already exists properly * handle new webhook event - payment_pointer.not_found * feat(middleware): add handling of axios errors (#719) * feat(middleware): add handling of axios errors * fix: avoid double response send * fix(deps): update dependency express-rate-limit to ^6.11.1 (#720) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @interledger/http-signature-utils to v1.0.4 (#724) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @tanstack/react-query to ^4.35.0 (#725) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency eslint to ^8.49.0 (#727) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(commerce/backend): add pre-interaction checkout flow (#723) * Draft * Progress * Make tests work again * Progress * Refactor * Remove calculateTotalAmount * Remove parseKey * Progress * Add cache * Rename fix * Add token cache * Update OP libraries * Downgrade `interledger/open-payments`: breaking changes * Fixes * Typo * Address feedback * fix(quote): change invalid amount error (#729) * fix(quote): change invalid amount error * fix: resolve lint issue * feat(commerce/frontend): add checkout view (#731) * Add checkout view * Backend changes * Fixes * fix(rapyd): add additional beneficiary fields on withdraw money (#730) * fix(rapyd): add additional beneficiary fields on withdraw money * fix: generate required fields * fix: remove console.log * fix: resolve some address issues * chore(deps): update typescript-eslint monorepo to ^6.7.0 (#735) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update pnpm to v8.7.5 (#734) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency express-rate-limit to ^6.11.2 (#736) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @tanstack/react-query to ^4.35.3 (#743) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest to ^29.7.0 (#744) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency react-router-dom to ^6.16.0 (#747) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(commerce): post-interaction checkout flow (#733) * Initial design for order confirmation page * Progress * More progress .. * Add orders worker * Finish checkout * Prevent multiple submissions * Address feedback * Address feedback * Address feedback * Refactor prepare method * Address feedback * Address feedback * chore(deps): update dependency @types/jest to ^29.5.5 (#752) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency uuid to ^9.0.1 (#751) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency express-rate-limit to v7 (#754) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/react to v18.2.22 (#759) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update typescript-eslint monorepo to ^6.7.2 (#760) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency postcss to ^8.4.30 (#761) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency sharp to ^0.32.6 (#762) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(commerce): verify interaction hash and add polling mechanism (#763) * Hash verification * Finish polling mechanism * Format * Fix tests --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: xplicit <111863110+beniaminmunteanu@users.noreply.github.com> Co-authored-by: dragosp1011 <109967337+dragosp1011@users.noreply.github.com>

raducristianpopa added 4 commits September 7, 2023 16:56

Draft

5936f93

Progress

a49c12d

Make tests work again

d1998b7

Progress

513599f

github-actions bot added type: test Improvements or additions to tests package: boutique/backend Boutique backend implementations labels Sep 8, 2023

raducristianpopa added 3 commits September 8, 2023 16:41

Refactor

faefdc2

Remove calculateTotalAmount

4ecefc9

Remove parseKey

0fe7d0e

raducristianpopa changed the title ~~feat(commerce/backend): add op client~~ feat(commerce/backend): add pre-interaction checkout flow Sep 8, 2023

raducristianpopa added 6 commits September 8, 2023 17:03

Progress

46fa03b

Add cache

a5f3ce6

Rename fix

9ce8fd1

Add token cache

1a2e3ee

Merge branch 'main' into rp--open-payments

69c4e17

Update OP libraries

5b93246

raducristianpopa force-pushed the rp--open-payments branch from f7388b4 to 5b93246 Compare September 11, 2023 05:16

Downgrade interledger/open-payments: breaking changes

a63ad44

raducristianpopa marked this pull request as ready for review September 11, 2023 05:26

raducristianpopa requested review from dragosp1011, beniaminmunteanu, rico191013 and Fsalker September 11, 2023 05:27

raducristianpopa commented Sep 11, 2023

View reviewed changes

Fixes

456e022

beniaminmunteanu reviewed Sep 11, 2023

View reviewed changes

.gitignore Show resolved Hide resolved

beniaminmunteanu reviewed Sep 11, 2023

View reviewed changes

dragosp1011 reviewed Sep 11, 2023

View reviewed changes

packages/commerce/backend/src/open-payments/service.ts Outdated Show resolved Hide resolved

Typo

0483468

raducristianpopa requested a review from beniaminmunteanu September 11, 2023 10:06

raducristianpopa requested a review from dragosp1011 September 11, 2023 10:06

dragosp1011 reviewed Sep 11, 2023

View reviewed changes

packages/commerce/backend/src/cache/token.ts Outdated Show resolved Hide resolved

dragosp1011 reviewed Sep 11, 2023

View reviewed changes

packages/commerce/backend/src/open-payments/service.ts Outdated Show resolved Hide resolved

dragosp1011 previously approved these changes Sep 11, 2023

View reviewed changes

raducristianpopa dismissed dragosp1011’s stale review via a51259b September 11, 2023 11:04

Address feedback

5b4a0be

raducristianpopa force-pushed the rp--open-payments branch from a51259b to 5b4a0be Compare September 11, 2023 11:07

raducristianpopa requested a review from dragosp1011 September 11, 2023 11:16

dragosp1011 approved these changes Sep 11, 2023

View reviewed changes

raducristianpopa merged commit d9da304 into main Sep 11, 2023
9 checks passed

raducristianpopa deleted the rp--open-payments branch September 11, 2023 12:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(commerce/backend): add pre-interaction checkout flow #723

feat(commerce/backend): add pre-interaction checkout flow #723

raducristianpopa commented Sep 8, 2023 •

edited

Loading

raducristianpopa Sep 11, 2023

dragosp1011 Sep 11, 2023

raducristianpopa Sep 11, 2023

dragosp1011 Sep 11, 2023

raducristianpopa Sep 11, 2023

beniaminmunteanu Sep 11, 2023

raducristianpopa Sep 11, 2023

feat(commerce/backend): add pre-interaction checkout flow #723

feat(commerce/backend): add pre-interaction checkout flow #723

Conversation

raducristianpopa commented Sep 8, 2023 • edited Loading

Context

Changes

raducristianpopa Sep 11, 2023

Choose a reason for hiding this comment

dragosp1011 Sep 11, 2023

Choose a reason for hiding this comment

raducristianpopa Sep 11, 2023

Choose a reason for hiding this comment

dragosp1011 Sep 11, 2023

Choose a reason for hiding this comment

raducristianpopa Sep 11, 2023

Choose a reason for hiding this comment

beniaminmunteanu Sep 11, 2023

Choose a reason for hiding this comment

raducristianpopa Sep 11, 2023

Choose a reason for hiding this comment

raducristianpopa commented Sep 8, 2023 •

edited

Loading