Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lock_configuration, unlock_configuration and load_configuration #153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krihal
Copy link

@krihal krihal commented Sep 2, 2019

Three new capabilities.

@fbouliane
Copy link
Contributor

Hi Kihal,
Thanks for the pull-request !

As we are trying to have achieve as much coverage in unit test as possible, do you have sample on how a real switch reacts when you issue those commands (xml rpc payload). I guess you can take a look at the netconf_protocol_test.py to understand how we test things. We could add those payloads to explain how the switch reacts to those commands.

Also, after a quick look I'm not sure adding those methods resulted in any feature. Does this change the initial capability message ?

Thanks again

Copy link
Contributor

@fbouliane fbouliane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would need more details as unit test or explanation of usage of the feature.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants