Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing for HTML tags (data-*) #323

Merged
merged 4 commits into from
Apr 23, 2020
Merged

Conversation

clawia
Copy link

@clawia clawia commented Apr 10, 2020

Add parsing for data-src, data-srcset, data-original and data-original-set tags to original ExtractorHTML.

@clawia
Copy link
Author

clawia commented Apr 22, 2020

@ato I have just pushed new version of ExtractorHTML with only my changes, not a formatting classe.
I add overrides in the JerochoExtractorHTMLTest for my news tests.
Is better for you?

Copy link
Collaborator

@ato ato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clawia! This looks good to me.

@ato ato merged commit 8dae196 into internetarchive:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants