Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies 2021 05 26 #389

Merged
merged 2 commits into from
May 26, 2021
Merged

Update dependencies 2021 05 26 #389

merged 2 commits into from
May 26, 2021

Conversation

anjackson
Copy link
Collaborator

This set of changes updates dependencies with known security issues.

Updating Jetty also means the tests need to be changed, as Jetty has changed how it formats responses. I have checked the WARCs from the relevant test, and the differences are like:

< Content-Length: 327
< Server: Jetty(9.4.19.v20190610)
---
> Content-Length: 448
> Server: Jetty(9.4.37.v20210219)
733,735c748,755
< <body><h2>HTTP ERROR 404</h2>
< <p>Problem accessing /link2.html. Reason:
< <pre>    Not Found</pre></p><hr><a href="http://eclipse.org/jetty">Powered by Jetty:// 9.4.19.v20190610</a><hr/>
---
> <body><h2>HTTP ERROR 404 Not Found</h2>
> <table>
> <tr><th>URI:</th><td>/link2.html</td></tr>
> <tr><th>STATUS:</th><td>404</td></tr>
> <tr><th>MESSAGE:</th><td>Not Found</td></tr>
> <tr><th>SERVLET:</th><td>-</td></tr>
> </table>
> <hr><a href="https://eclipse.org/jetty">Powered by Jetty:// 9.4.37.v20210219</a><hr/>

As these changes seem acceptable, I have updated the tests so the expected values match those being generated.

@anjackson anjackson merged commit 3b4c442 into internetarchive:master May 26, 2021
@anjackson anjackson deleted the update-dependencies-2021-05-26 branch May 26, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anjackson