Fix Linux installation problem, move fsevents to optional dependencies #22

shreyansh23 · 2019-03-24T12:52:13Z

Description: What does this PR achieve? [feature|hotfix|refactor]

Fix issue issue in Linux installation + Migrate to Babel 7 🎉
Related to PR #19
Closes issue #16

Earlier there were problems in Linux installation. The problem was due to fsevents package.
The babel version 6 was used. But the testing required version 7. So, the tests were failing! (Ref).

Solution

fsevents is moved to optionalDependencies which is where it should be present.
Migrate Babel from version 6 to 7

Implementation
Implemenation was done following the steps suggested by https://babeljs.io/docs/en/configuration

Technical: What should be noted about the implementation?

n/a

Testing: Steps for reviewer to reproduce / verify this PR fixes the problem?

Can be tested by pulling the branch. Then follow the steps suggested in the README.md
Steps:

yarn run lerna bootstrap
yarn run lerna link
cd packages/ia-components
yarn run storybook

Evidence: If this PR touches UI, please post evidence (screenshot) of it behaving correctly:

shreyansh23 · 2019-03-24T12:52:48Z

@bfalling @iisa @mekarpeles
Please review the PR

mitra42 · 2019-03-24T14:56:38Z

Careful with Babel - it seems that none of us really understand it, and there are incompatibilities with what you have to include in what config files (babel.rc and webpack.config) for different versions. I have a complete mess in the IAUX2 branch of dweb-archive and cannot find any combination of babel that will run properly with webpack and also at runtime. On Friday @iisa and I got it compiling with up to date babel, but it complained about a runtime missing - adding the runtime meant it wouldn't compile.

mitra42 · 2019-03-24T14:56:53Z

If you want to try this ....
Check out dweb-mirror#iaux2 and checkout iaux#dwebnew. They should be in side-by-side directories (e.g. git/dweb-mirror and git/iaux ). Then try cd dweb-mirror && webpack --mode development. I cannot get it to webpack except by removing some things, in particular plugin-transform-runtime and it seems to need one of those plugins to run in the browser (Its not clear if its babel-plugin-transform-runtime or @babel/plugin-transform-runtime).

Note - you'll probably need to do cd dweb-mirror && yarn install and also maybe cd dweb-mirror && ./install.sh before webpack-ing.

If you figured out how to get this to work it would be huge.

iisa

@shreyansh23 thanks for the start off this.a couple of questions.

packages/ia-design-system/webpack.config.js

iisa · 2019-03-24T16:39:09Z

packages/ia-components/package.json

@@ -21,9 +21,10 @@
        "@storybook/addon-knobs": "^4.1.4",
        "@storybook/react": "^4.1.4",
        "assert": "^1.4.1",
+        "babel-core": "^7.0.0-bridge.0",


Question: why are we using babel-core instead of @babel/core v. 7?

we already use "@babel/core": "^7.2.2", at the first line, we should not need the two unless it is for a certain reason.

@iisa
Your concern is valid. I will need to check with docs and babel-upgrade package which I used for upgrading the version. I will do some research and reply.

@iisa I think this happened because ia-components/package.json was already using Babel 7 and babel-upgrade package which I used was designed to migrate from Babel 6 to Babel 7. So changes in this package.json were not required. Thanks for reviewing.
I will update the PR.

@iisa I just checked the the babel-upgrade package's documentation. Please have a look. Ref: https://github.com/babel/babel-upgrade

Relevant Screenshot from the page:

Hence the behavior was intendend.

Jest JS docs say otherwise. Perhaps upgrade tool is behind. Pleaes double check. https://jestjs.io/docs/en/getting-started

@iisa I again cross-checked.
It is strange but babel-core is needed in case of jestJS.
Relevant links:
1: jestjs/jest#6913 (comment)
2: jestjs/jest#6662 (comment)
All the the solutions say the same thing, i.e. keep both @babel/core and babel-core in case of jest as a dependency.
So I strongly think that the babel-upgrade is doing the right thing.
Also if you see link 1, removing babel-core gives errors.
So concluding on the note that babel-upgrade is doing the right thing in my opinion.

shreyansh23 · 2019-03-24T18:23:02Z

If you want to try this ....
Check out dweb-mirror#iaux2 and checkout iaux#dwebnew. They should be in side-by-side directories (e.g. git/dweb-mirror and git/iaux ). Then try cd dweb-mirror && webpack --mode development. I cannot get it to webpack except by removing some things, in particular plugin-transform-runtime and it seems to need one of those plugins to run in the browser (Its not clear if its babel-plugin-transform-runtime or @babel/plugin-transform-runtime).

Note - you'll probably need to do cd dweb-mirror && yarn install and also maybe cd dweb-mirror && ./install.sh before webpack-ing.

If you figured out how to get this to work it would be huge.

@mitra42
I will definitely try that.

traceypooh · 2019-03-24T18:33:52Z

@mitra42 well, technically speaking i understand babel very well.
i set us up with it ~4y+ ago;
then moved us from a "push out" script to package.json script;
then helped move it to webpack

the problem has been more in last ~2y we haven't been as rigorous about testing updates -- IE esp. got a bit tricky some additional polyfill requirements, etc.

shreyansh23 · 2019-03-24T18:39:11Z

@traceypooh Would you also please review the PR. I think we should leave no stone unturned.

mitra42 · 2019-03-24T22:01:23Z

Glad to hear that @traceypooh, we didn't think to ask you.

Even on stackexchange people dont seem to fully understand what versions of what packages are needed for current versions, and the problem seems to be that babel does a crappy job of defining dependencies so if you don't have just the right set it gives incomprehensible error messages.

iisa

more comments @shreyansh23

iisa · 2019-03-25T16:19:53Z

packages/ia-components/package.json

@@ -21,9 +21,10 @@
        "@storybook/addon-knobs": "^4.1.4",
        "@storybook/react": "^4.1.4",
        "assert": "^1.4.1",
+        "babel-core": "^7.0.0-bridge.0",


Jest JS docs say otherwise. Perhaps upgrade tool is behind. Pleaes double check. https://jestjs.io/docs/en/getting-started

iisa · 2019-03-25T16:20:39Z

packages/ia-components/yarn.lock

@@ -2077,6 +2077,11 @@ babel-core@^6.0.0, babel-core@^6.26.0:
    slash "^1.0.0"
    source-map "^0.5.7"

+babel-core@^7.0.0-bridge.0:


please note to update yarn.lock once this is resolved

iisa · 2019-03-25T16:21:45Z

packages/ia-prototype-apps/package.json

@@ -4,19 +4,20 @@
  "license": "AGPL-3.0-only",
  "private": true,
  "dependencies": {
-    "babel-preset-react": "^6.24.1",
+    "@babel/core": "^7.0.0",


@babel/core has been added twice, here and in devDependencies.

iisa · 2019-03-29T17:59:13Z

@shreyansh23 hi, can you pull the FSEvents to optional dependency as its own PR?

shreyansh23 · 2019-03-29T18:19:24Z

Updating this PR.
This PR only fixed move fsevents to optional dependencies.
Babel Migration is handled by PR #51

iisa

LGTM

iisa · 2019-03-29T18:24:44Z

Babel upgrade has been moved to a different PR #51

shreyansh23 mentioned this pull request Mar 24, 2019

Move fsevents to optional dependencies in package.json #19

Closed

iisa requested changes Mar 24, 2019

View reviewed changes

iisa requested changes Mar 25, 2019

View reviewed changes

Move fsevents to optional dependencies in package.json

b2d9f80

shreyansh23 mentioned this pull request Mar 29, 2019

Migrate Babel from version 6 to version 7 #51

Closed

shreyansh23 force-pushed the hotfix/linux-fsevents branch from dd6115b to b2d9f80 Compare March 29, 2019 18:16

shreyansh23 changed the title ~~Fix Linux installation problem + Migrate to Babel 7~~ Fix Linux installation problem, move fsevents to optional dependencies Mar 29, 2019

iisa approved these changes Mar 29, 2019

View reviewed changes

iisa merged commit 80dee08 into internetarchive:master Mar 29, 2019

shreyansh23 mentioned this pull request Mar 30, 2019

Installation steps fails for Ubuntu 18.04 #16

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Linux installation problem, move fsevents to optional dependencies #22

Fix Linux installation problem, move fsevents to optional dependencies #22

shreyansh23 commented Mar 24, 2019 •

edited

Loading

shreyansh23 commented Mar 24, 2019

mitra42 commented Mar 24, 2019

mitra42 commented Mar 24, 2019

iisa left a comment

iisa Mar 24, 2019

iisa Mar 24, 2019

shreyansh23 Mar 24, 2019

shreyansh23 Mar 24, 2019 •

edited

Loading

iisa Mar 25, 2019

shreyansh23 Mar 25, 2019

shreyansh23 commented Mar 24, 2019

traceypooh commented Mar 24, 2019

shreyansh23 commented Mar 24, 2019

mitra42 commented Mar 24, 2019

iisa left a comment

iisa Mar 25, 2019

iisa Mar 25, 2019

iisa Mar 25, 2019

iisa commented Mar 29, 2019

shreyansh23 commented Mar 29, 2019

iisa left a comment

iisa commented Mar 29, 2019

Fix Linux installation problem, move fsevents to optional dependencies #22

Fix Linux installation problem, move fsevents to optional dependencies #22

Conversation

shreyansh23 commented Mar 24, 2019 • edited Loading

shreyansh23 commented Mar 24, 2019

mitra42 commented Mar 24, 2019

mitra42 commented Mar 24, 2019

iisa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shreyansh23 Mar 24, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shreyansh23 commented Mar 24, 2019

traceypooh commented Mar 24, 2019

shreyansh23 commented Mar 24, 2019

mitra42 commented Mar 24, 2019

iisa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iisa commented Mar 29, 2019

shreyansh23 commented Mar 29, 2019

iisa left a comment

Choose a reason for hiding this comment

iisa commented Mar 29, 2019

shreyansh23 commented Mar 24, 2019 •

edited

Loading

shreyansh23 Mar 24, 2019 •

edited

Loading