Add "Search inside" link above global search form #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f405dcc.
mekarpeles
requested changes
Oct 3, 2016
| @@ -43,7 +46,7 @@ | |||
| </div> | |||
| </fieldset> | |||
| </div> | |||
|
|
|||
There was a problem hiding this comment.
this may be removed in a later commit, looks like whitespace was added
| # cache the results of get_returncart in memcache for 60 sec | ||
| get_returncart = cache.memcache_memoize(get_returncart, "home.get_returncart", timeout=60) | ||
|
|
||
| @public | ||
| def readonline_carousel(id="read-carousel"): | ||
| """Return template code for books pulled from search engine. TODO: If probs, use stock list.""" |
There was a problem hiding this comment.
syntactic qualm; suspected 80 line length violation
| @@ -151,15 +152,15 @@ def format_list_editions(key): | |||
| """ | |||
| if 'env' not in web.ctx: | |||
| delegate.fakeload() | |||
|
|
|||
| list = web.ctx.site.get(key) | |||
There was a problem hiding this comment.
Not a critique of this CR, but we should not be overriding the list function. Consider lst instead or seed_list.
| @@ -131,16 +132,16 @@ def process_doc(doc): | |||
|
|
|||
| d['url'] = key | |||
| d['title'] = doc.get('title', '') | |||
|
|
|||
| if 'author_key' in doc and 'author_name' in doc: | |||
There was a problem hiding this comment.
This isn't a critique of your changes, rather a general question -- is there any case where doc could be None?
This was referenced Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving "Search inside" link to above search form instead of below