Prevent PRs from breaking Python 3 tests #3345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't believe how cavalier the Open Library staff is being about supporting Python 3! If you're not going to support Christian, at the very least don't actively work against him!! As a reminder Python 2 was due to be retired Jan. 1, but they decided to do one final 2.7 maintenance release which just had a release candidate cut . The means we are weeks away from the end of security patches for all production Open Library systems running 2.7. People should have been writing Python 3 clean code for over a year now! @mekarpeles What will it take to Open Library staff commitment to writing Python 3 clean code from now on? |
cclauss
added
the
Needs: Review
mekarpeles
approved these changes
Apr 12, 2020
77 tasks
mekarpeles
added
python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New pull requests are breaking Python 3 pytests that are already passing. See: #3335 (comment) and #3081 (comment) This change ensures that Travis CI will fail the build when this happens. This is done in a way that allows all tests to be run on Python 3 but only those tests that have already been fixed will fail the build.
I would like to have this fast tracked because it is quite difficult and time consuming to clean up code after it has been landed.
Technical
Testing
Evidence
Stakeholders