Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI: Test on the current infogami master #3579

Merged
merged 7 commits into from
Jul 16, 2020
Merged

Travis CI: Test on the current infogami master #3579

merged 7 commits into from
Jul 16, 2020

Conversation

cclauss
Copy link
Collaborator

@cclauss cclauss commented Jul 14, 2020

Closes #

Technical

Testing

Screenshot

Stakeholders

@cclauss cclauss added Theme: Upgrade to Python 3 State: Work In Progress This issue is being actively worked on. [managed] labels Jul 14, 2020
@cclauss cclauss added this to the Active Sprint milestone Jul 14, 2020
@cclauss cclauss changed the title Travis CI: Test on the current infogami and node-gyp Travis CI: Test on the current infogami master Jul 14, 2020
@cclauss cclauss marked this pull request as ready for review July 14, 2020 11:18
@cclauss cclauss added Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] and removed State: Work In Progress This issue is being actively worked on. [managed] labels Jul 14, 2020
.travis.yml Outdated
pushd vendor/infogami && git pull origin master && popd;
fi
# refresh the git submodule ./vendor/infogami
- pushd vendor/infogami && git pull origin master && popd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a new job for Py2 + Infogami master with allow_failures. Since we're actively developing on both infogami and openlibrary, we don't want everyone working on openlibrary to be blocked if a bug gets into infogami master.

(Since openlibrary depends on infogami, there's ~no chance that an openlibrary edit will cause infogami to break. Bugs can only be introduced in the other direction; i.e. an infogami edit can cause openlibrary to break (which is why openlibrary is pinned to specific version of infogami known to work). So the only thing we care about is if an infogami edit causes things to break.)

@cdrini cdrini self-assigned this Jul 14, 2020
@cclauss cclauss mentioned this pull request Jul 16, 2020
77 tasks
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed latest infogami is loaded in Travis logs for the new job, and not for the others. Lgtm!

@cdrini cdrini merged commit 4f126e6 into internetarchive:master Jul 16, 2020
@cclauss cclauss deleted the travis-infogami-master-on-openlibrary branch July 16, 2020 15:11
@mekarpeles mekarpeles added python Pull requests that update Python code and removed Module: Python labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants