Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doctests of UnitParser for Python 2 and 3 #3657

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Fix doctests of UnitParser for Python 2 and 3 #3657

merged 1 commit into from
Aug 12, 2020

Conversation

cclauss
Copy link
Collaborator

@cclauss cclauss commented Aug 3, 2020 •
edited
Loading

Closes #

Technical

Testing

  • python2 -m pytest --doctest-modules openlibrary/plugins/upstream/models.py
  • python3 -m pytest --doctest-modules openlibrary/plugins/upstream/models.py

Screenshot

Stakeholders

@cdrini cdrini self-assigned this Aug 4, 2020
@cclauss cclauss added Python Theme: Testing Involves work related to testing infrastructure, development, and ops. [managed] labels Aug 10, 2020
@cclauss cclauss mentioned this pull request Aug 10, 2020
Closed
77 tasks
@cclauss cclauss added this to the Active Sprint milestone Aug 11, 2020
cdrini
cdrini approved these changes Aug 12, 2020
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@cdrini cdrini merged commit cea31c6 into master Aug 12, 2020
@cdrini cdrini deleted the Fix-doctests-of-UnitParser branch August 12, 2020 21:42
@mekarpeles mekarpeles added python Pull requests that update Python code and removed Module: Python labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrini cdrini cdrini approved these changes

@mekarpeles mekarpeles Awaiting requested review from mekarpeles

Assignees

@cdrini cdrini

Labels
python Pull requests that update Python code Theme: Testing Involves work related to testing infrastructure, development, and ops. [managed]
Projects
None yet
Milestone
Sprint 2020-08
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @cdrini @mekarpeles