Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable doctests #3683

Merged
merged 3 commits into from
Aug 17, 2020
Merged

Re-enable doctests #3683

merged 3 commits into from
Aug 17, 2020

Conversation

cclauss
Copy link
Collaborator

@cclauss cclauss commented Aug 11, 2020

Add scripts/run_doctests.sh to run Python doctests on both Python 2 and 3.

Fixes #3586, #3659, #3673 which got into bad git states because of `vendors/infogami".

Output:

495 passed, 25 skipped, 10 xfailed, 35 warnings in 87.36s (0:01:27)

Technical

Passing these tests required several absolute import changes, etc.

Testing

Yes! 495 of them.

Screenshot

Stakeholders

@cclauss cclauss mentioned this pull request Aug 11, 2020
@cclauss cclauss added Python Theme: Testing Involves work related to testing infrastructure, development, and ops. [managed] labels Aug 11, 2020
@cclauss cclauss added this to the Active Sprint milestone Aug 11, 2020
@cclauss cclauss mentioned this pull request Aug 11, 2020
77 tasks
@cclauss
Copy link
Collaborator Author

cclauss commented Aug 14, 2020

Which files would it make sense to remove from this PR to make it easier to review and merge?

Please check the files that you want me to remove...

  • openlibrary/api.py
  • openlibrary/catalog/amazon/parse.py
  • openlibrary/catalog/marc/build_record.py
  • openlibrary/catalog/marc/read_toc.py
  • openlibrary/catalog/merge/build_db.py
  • openlibrary/catalog/merge/load_from_json.py
  • openlibrary/catalog/merge/merge_bot/bot.py
  • openlibrary/catalog/merge/merge_bot/merge.py
  • openlibrary/catalog/merge/merge_index.py
  • openlibrary/core/helpers.py
  • openlibrary/core/seq.py
  • openlibrary/data/__init__.py
  • openlibrary/data/dump.py
  • openlibrary/data/solr.py
  • openlibrary/olbase/events.py
  • openlibrary/plugins/akismet/code.py
  • openlibrary/plugins/importapi/metaxml_to_json.py
  • openlibrary/plugins/openlibrary/support.py
  • openlibrary/plugins/upstream/account.py
  • openlibrary/plugins/upstream/code.py
  • openlibrary/plugins/upstream/tests/test_utils.py
  • openlibrary/plugins/upstream/utils.py
  • openlibrary/solr/solrdump.py
  • openlibrary/solr/update_work.py
  • openlibrary/templates/type/edition/view.html
  • openlibrary/utils/__init__.py
  • openlibrary/utils/dateutil.py
  • openlibrary/utils/form.py
  • openlibrary/utils/httpserver.py
  • openlibrary/utils/schema.py
  • scripts/solr_builder/solr_builder/solr_builder.py
  • scripts/solr_builder/solr_builder/solr_builder_main.py

Copy link
Member

@mekarpeles mekarpeles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look okay to me.

@mekarpeles mekarpeles merged commit 05c0564 into internetarchive:master Aug 17, 2020
@cclauss cclauss deleted the re-enable-doctests branch August 17, 2020 04:13
@mekarpeles mekarpeles added python Pull requests that update Python code and removed Module: Python labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code Theme: Testing Involves work related to testing infrastructure, development, and ops. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How do we modernize pytest_funcarg__xyz() tests?
2 participants