Create solr-updater docker service AGAIN #4287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
added
Module: Solr
This was referenced Dec 16, 2020
cclauss
changed the title
6 tasks
- Mount /openlibrary so can access local version of code - Was getting errors about access; needs to ping both web and db - Ugh, named volumes are created as root by default :/ Internet recommends pre-creating the directory with the right perms in the Dockerfile. - Turns out a named volume can't be a single file :) The more you know!
cdrini
approved these changes
Dec 31, 2020
There was a problem hiding this comment.
Ok, tested, fixed some bugs, and it's working! Fixes:
- Mount /openlibrary so can access local version of code
- Was getting errors about access; needs to ping both web and db
- Ugh, named volumes are created as root by default :/ Internet recommends pre-creating the directory with the right perms in the Dockerfile.
- Turns out a named volume can't be a single file :) The more you know!
Could you do another test, @cclauss and then merge at your discretion. To test:
cd vendor/infogami
git pull origin master
cd ../..
export COMPOSE_FILE="docker-compose.yml:docker-compose.override.yml:docker-compose.infogami-local.yml"
PYENV_VERSION=3.8.6 docker-compose up -d
docker-compose logs -f solr-updater
# Open the site and edit a book; it should log some stuffDISCLAIMER: I did something slightly differently, but that should work 👍
|
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
* Create solr-updater docker service AGAIN * Fixes to solr-updater volume mounts - Mount /openlibrary so can access local version of code - Was getting errors about access; needs to ping both web and db - Ugh, named volumes are created as root by default :/ Internet recommends pre-creating the directory with the right perms in the Dockerfile. - Turns out a named volume can't be a single file :) The more you know! * Remove no longer needed solr/solr-updater gitignores Co-authored-by: Drini Cami <cdrini@gmail.com>
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
* Create solr-updater docker service AGAIN * Fixes to solr-updater volume mounts - Mount /openlibrary so can access local version of code - Was getting errors about access; needs to ping both web and db - Ugh, named volumes are created as root by default :/ Internet recommends pre-creating the directory with the right perms in the Dockerfile. - Turns out a named volume can't be a single file :) The more you know! * Remove no longer needed solr/solr-updater gitignores Co-authored-by: Drini Cami <cdrini@gmail.com>
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
* Create solr-updater docker service AGAIN * Fixes to solr-updater volume mounts - Mount /openlibrary so can access local version of code - Was getting errors about access; needs to ping both web and db - Ugh, named volumes are created as root by default :/ Internet recommends pre-creating the directory with the right perms in the Dockerfile. - Turns out a named volume can't be a single file :) The more you know! * Remove no longer needed solr/solr-updater gitignores Co-authored-by: Drini Cami <cdrini@gmail.com>
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
* Create solr-updater docker service AGAIN * Fixes to solr-updater volume mounts - Mount /openlibrary so can access local version of code - Was getting errors about access; needs to ping both web and db - Ugh, named volumes are created as root by default :/ Internet recommends pre-creating the directory with the right perms in the Dockerfile. - Turns out a named volume can't be a single file :) The more you know! * Remove no longer needed solr/solr-updater gitignores Co-authored-by: Drini Cami <cdrini@gmail.com>
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
* Create solr-updater docker service AGAIN * Fixes to solr-updater volume mounts - Mount /openlibrary so can access local version of code - Was getting errors about access; needs to ping both web and db - Ugh, named volumes are created as root by default :/ Internet recommends pre-creating the directory with the right perms in the Dockerfile. - Turns out a named volume can't be a single file :) The more you know! * Remove no longer needed solr/solr-updater gitignores Co-authored-by: Drini Cami <cdrini@gmail.com>
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 15, 2021
* Create solr-updater docker service AGAIN * Fixes to solr-updater volume mounts - Mount /openlibrary so can access local version of code - Was getting errors about access; needs to ping both web and db - Ugh, named volumes are created as root by default :/ Internet recommends pre-creating the directory with the right perms in the Dockerfile. - Turns out a named volume can't be a single file :) The more you know! * Remove no longer needed solr/solr-updater gitignores Co-authored-by: Drini Cami <cdrini@gmail.com>
mekarpeles
added
python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4244 (which got in a bad git state and was closed)
Related to #4060
Borrows from https://github.com/internetarchive/olsystem/blob/master/etc/supervisor/conf.d/solr-updater.conf to build a Docker service that can be run from ol-home0 to execute solr-updater.
Technical
Testing
Screenshot
Stakeholders