Code

880 alternate script handling#7652

Code

Merged

hornc merged 66 commits intointernetarchive:masterinternetarchive/openlibrary:masterfrom hornc:880_alternate_scriptshornc/openlibrary-1:880_alternate_scriptsCopy head branch name to clipboardApr 6, 2023

+691-553

Commits

Commits on Mar 15, 2023

• add 880 alternate script test data

  hornc

  committed
  029f3b7

  Copy full SHA for 029f3b7

• use format strings and pytest.fail

  hornc

  committed
  cef8ec0

  Copy full SHA for cef8ec0

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for fc66576
  

  pre-commit-ci[bot]

  authored and

  hornc

  committed
  fc66576

  Copy full SHA for fc66576

• 880 expectations initial commit

  Show description for 25b7a18
  hornc

  committed
  25b7a18

  Copy full SHA for 25b7a18

• fix MARC leader incorrect encoding at leader$9

  Show description for 23317e2
  hornc

  committed
  23317e2

  Copy full SHA for 23317e2

• title in original script

  hornc

  committed
  e70dff2

  Copy full SHA for e70dff2

Commits on Mar 16, 2023

• get alt script title test passing

  hornc

  committed
  2c3802c

  Copy full SHA for 2c3802c

• reduce subfields and repetition

  hornc

  committed
  f8878e4

  Copy full SHA for f8878e4

• better missing title concatenation

  hornc

  committed
  c5fc6f1

  Copy full SHA for c5fc6f1

• refactor title concatenation code

  hornc

  committed
  f51877d

  Copy full SHA for f51877d

• add test for TOC case from internetarchive#7617

  hornc

  committed
  9d1e899

  Copy full SHA for 9d1e899

• add Nihon no chasho test example

  hornc

  committed
  ceb26ff

  Copy full SHA for ceb26ff

• add new unlinked publisher testcase, with alt subtitle

  hornc

  committed
  dafe34f

  Copy full SHA for dafe34f

• get_linkage() type hints

  Show description for 0963ac9
  

  hornc

  and

  cclauss

  authored
  0963ac9

  Copy full SHA for 0963ac9

• BinaryDataField or None return type

  hornc

  committed
  8ff632a

  Copy full SHA for 8ff632a

• title_from_list() type hints

  Show description for 16a4015
  

  hornc

  and

  cclauss

  authored
  16a4015

  Copy full SHA for 16a4015

• publisher from 880, add original script subtitle

  hornc

  committed
  e2fdcb4

  Copy full SHA for e2fdcb4

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for 5108da7
  pre-commit-ci[bot]

  committed
  5108da7

  Copy full SHA for 5108da7

• add another recent import example with many 880 fields and edition issue

  hornc

  committed
  bd9d2a0

  Copy full SHA for bd9d2a0

Commits on Mar 17, 2023

• import alternate script author names

  hornc

  committed
  0dc5b20

  Copy full SHA for 0dc5b20

• clean up some existing test data with improvements

  hornc

  committed
  d128a67

  Copy full SHA for d128a67

• remove deprecated remove_brackets() now all have been replaced

  hornc

  committed
  01194c4

  Copy full SHA for 01194c4

• explicit returns because of mypy

  hornc

  committed
  b598734

  Copy full SHA for b598734

• more precise type hints without over-specifying at this stage

  hornc

  committed
  bf5511b

  Copy full SHA for bf5511b

Commits on Mar 19, 2023

• type hints

  hornc

  committed
  9c392b6

  Copy full SHA for 9c392b6

• NFC normalised UTF-8 in expectations JSON

  hornc

  committed
  c979531

  Copy full SHA for c979531

Commits on Mar 20, 2023

• get MarcXml working equivalent to MarcBinary

  hornc

  committed
  111347e

  Copy full SHA for 111347e

• Iterator from collections.abc

  hornc

  committed
  a692e85

  Copy full SHA for a692e85

• remove commented out line

  hornc

  committed
  e0c070f

  Copy full SHA for e0c070f

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for 7a6d0b6
  pre-commit-ci[bot]

  committed
  7a6d0b6

  Copy full SHA for 7a6d0b6

• dict Any

  hornc

  committed
  713859b

  Copy full SHA for 713859b

• MarcBase.read_fields()

  hornc

  committed
  9138e51

  Copy full SHA for 9138e51

• remove unused file

  hornc

  committed
  a5dcfd1

  Copy full SHA for a5dcfd1

• remove build_fields() method

  hornc

  committed
  950d677

  Copy full SHA for 950d677

• move get_subfield_values() to MarcFieldBase

  hornc

  committed
  04388d9

  Copy full SHA for 04388d9

• type hints

  hornc

  committed
  7c58e24

  Copy full SHA for 7c58e24

• more type hints in MARC parse

  hornc

  committed
  e0f7117

  Copy full SHA for e0f7117

• return types

  hornc

  committed
  72c4382

  Copy full SHA for 72c4382

• refactoring types

  hornc

  committed
  171fcb7

  Copy full SHA for 171fcb7

• move get_contents() to MarcFieldBase

  hornc

  committed
  ab4f829

  Copy full SHA for ab4f829

• simplify subfield 'want' to a str (i.e. a list of chars)

  hornc

  committed
  9738e47

  Copy full SHA for 9738e47

• subfield wants are now str

  hornc

  committed
  dad53e7

  Copy full SHA for dad53e7

• refactoring

  hornc

  committed
  3bf8654

  Copy full SHA for 3bf8654

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for 44638e2
  pre-commit-ci[bot]

  committed
  44638e2

  Copy full SHA for 44638e2

• further refactoring

  hornc

  committed
  bbf0faf

  Copy full SHA for bbf0faf

• correct type for MARC binary indicators

  hornc

  committed
  f20da8d

  Copy full SHA for f20da8d

• simplify str/bytes

  hornc

  committed
  1f37107

  Copy full SHA for 1f37107

Commits on Mar 21, 2023

• refactor common MARC field code

  hornc

  committed
  c79d738

  Copy full SHA for c79d738

• remove unused method all_fields(), show binary read_fields() has the same function

  hornc

  committed
  0571736

  Copy full SHA for 0571736

• strip trailing punctuation and dedupe series. Add type hints to MARC fields

  hornc

  committed
  93c0bd0

  Copy full SHA for 93c0bd0

• add a get_control() method to avoid field polymorphism issues

  hornc

  committed
  c1e3a88

  Copy full SHA for c1e3a88

• return values

  hornc

  committed
  967949e

  Copy full SHA for 967949e

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for 7e4eb22
  pre-commit-ci[bot]

  committed
  7e4eb22

  Copy full SHA for 7e4eb22

• resolve type warnings in marc_base

  hornc

  committed
  69a942a

  Copy full SHA for 69a942a

• resolve most type issues in parse.py

  hornc

  committed
  2b8eba9

  Copy full SHA for 2b8eba9

• Merge branch 'master' into 880_alternate_scripts

  hornc

  authored
  9e7e76a

  Copy full SHA for 9e7e76a

Commits on Mar 23, 2023

• abstractmethod decorators for base classes

  hornc

  committed
  011718d

  Copy full SHA for 011718d

• type for MarcFieldBase.re

  hornc

  committed
  b189b10

  Copy full SHA for b189b10

Commits on Mar 24, 2023

• placate mypy

  Show description for b89a1fe
  

  hornc

  and

  cclauss

  authored
  b89a1fe

  Copy full SHA for b89a1fe

• placate mypy

  Show description for 9c84c5c
  

  hornc

  and

  cclauss

  authored
  9c84c5c

  Copy full SHA for 9c84c5c

• remove unneeed assert

  Show description for c245d9e
  

  hornc

  and

  cclauss

  authored
  c245d9e

  Copy full SHA for c245d9e

• final mypy placation ✅ 🤞

  hornc

  committed
  8d41b31

  Copy full SHA for 8d41b31

Commits on Mar 29, 2023

• retain common abbreviations [s.n.], [s.l.], and [n.d.] in publisher

  Show description for e808419
  hornc

  committed
  e808419

  Copy full SHA for e808419

• remove entirely bracketed subtitles

  hornc

  committed
  62ef5dd

  Copy full SHA for 62ef5dd

• correct author's name in source MARC and expectation

  hornc

  committed
  0d65498

  Copy full SHA for 0d65498

• don't change $q fuller_name code in this PR

  hornc

  committed
  e5f42cc

  Copy full SHA for e5f42cc