-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
author page infobox #8949
author page infobox #8949
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice looks good! I think longer term we might want to have a discussion about how to structure this page; eg the subjects I think do make sense above the list of books on mobile (similar to our books pages with collapsing), but considering out of scope for now, since this is just a stepping stone for some of the wikidata changes we wish to make. As such I'm mainly considering whether this will have negative consequences for any existing workflows. So let's get some librarian eyes since they use birth/death date a lot for deduping authors.
I do think we should move the Author name from above the photo to below and adjust spacing as needed to make things balanced. Otherwise lgtm!
@cdrini all the changes discussed and approved on the call today are here!
Try it out: https://testing.openlibrary.org/authors/OL1394244A/ We are ready to merge 🚀 |
@cdrini please let me know if there is anything else I need to do here. As far as I know all feedback has been incorporated. |
CLOSED IN FAVOR OF #9130 |
CLOSED IN FAVOR OF #9130
This contributes to the Wikidata project #8236
This is on testing now: https://testing.openlibrary.org/authors/OL345358A/
It creates an infobox for the author page that includes:
Why?
Technical
Screenshot
After - using the style of the search results
Dates
No Dates
Before
Old Mockups after - using wikipedia style
Dates
No Dates (doesn't look as nice)
Stakeholders
@mekarpeles