Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Needs: Submitter Input label on push #9204

Merged
merged 1 commit into from
May 8, 2024

Conversation

jimchamp
Copy link
Collaborator

@jimchamp jimchamp commented May 1, 2024

Closes #9199

Removes any existing Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] labels from PRs when the pull request's head branch is updated.

Technical

The pull_request_target event was chosen over pull_request event, as the workflow will not run for pull_request events if there is a merge conflict (more details here).

Our labeler configuration is set to add a Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label if the PR includes changes to any file in the project's non-existent dev/null directory. When coupled with a truthy sync-labels input, the label is removed every time there is no change to any dev/null file. This isn't the most intuitive way to remove labels, but is recommended by the action's team (here).

.github/labeler.yml is the default path for the labeler's configuration file. If we want to move this elsewhere, the path is configurable (not that I'm suggesting that we move the file --- just pointing out that we can).

Testing

  1. Merge this branch into the master branch of your repo (not this one)
  2. Open a PR in your repo that makes a small change (maybe a README update)
  3. Label the new PR Needs: Submitter Input. You'll likely have to create this label in your repo --- be sure to use the exact string when creating the label.
  4. Update the PR. The Needs: Submitter Input label should be removed after the action finishes. Any other labels should be unaffected.

Screenshot

Stakeholders

@mekarpeles mekarpeles self-assigned this May 6, 2024
@mekarpeles mekarpeles added Priority: 2 Important, as time permits. [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] and removed Priority: 2 Important, as time permits. [managed] labels May 6, 2024
@mekarpeles mekarpeles merged commit 730588d into internetarchive:master May 8, 2024
3 checks passed
@jimchamp jimchamp deleted the pr-actions branch May 30, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR "Submitter Input" Github Bot
2 participants