https://github.com/internetarchive/umbra/pull/54 plus more refactoring #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring script template system.
…e for appropriate templates.
…populate templates until starting behavior; send amqp message on Network.responseReceived event instead of Network.requestWillBeSent, because it has request info that we need, like cookies
nlevitt
added a commit
to nlevitt/heritrix3
that referenced
this pull request
Feb 19, 2016
…ertain http headers, since with internetarchive/umbra#55 umbra sends over more stuff
nlevitt
added a commit
to vonrosen/heritrix3
that referenced
this pull request
Feb 19, 2016
* ari-4638: remove stray line new parameter extraInfo, "Arbitrary additional information to include in the json payload", on AMQPPublishProcessor; used KeyedProperties so parameters can be overridden with the sheet/overlay system set custom http headers last, so they override headers set elsewhere (e.g. cookies) new boolean forceFetch setting; REQUEST_HEADER_BLACKLIST to exclude certain http headers, since with internetarchive/umbra#55 umbra sends over more stuff ARI-4528 avoid this exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.