refactored

internetee · Aug 29, 2023 · c70a1e8 · c70a1e8
1 parent 7bedf36
commit c70a1e8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/Gemfile b/Gemfile
@@ -90,10 +90,9 @@ group :test do
   gem 'database_cleaner'
   gem 'minitest', '~> 5.17'
   gem 'minitest-stub_any_instance'
+  gem 'selenium-webdriver'
   gem 'simplecov', '0.17.1', require: false # CC last supported v0.17
   gem 'spy'
-  # gem 'webdrivers'
-  gem 'selenium-webdriver'
   gem 'webmock'
 end
 

diff --git a/app/interactions/actions/email_check.rb b/app/interactions/actions/email_check.rb
@@ -73,10 +73,10 @@ def handle_mx_validation(result)
         output_a_and_aaaa_validation_results(email: email, result: result_validation, type: 'AAAA')
       end
 
-      if result_validation.present?
-        result.success = true
-        result.errors.merge!({ mx: 'target host(s) not found, but was able to find A/AAAA records for domain'})
-      end
+      return if result_validation.blank?
+
+      result.success = true
+      result.errors.merge!({ mx: 'target host(s) not found, but was able to find A/AAAA records for domain' })
     end
 
     def handle_saving_result(contact, result)