Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Sidekiq #198

Closed
artur-intech opened this issue Oct 5, 2016 · 9 comments
Closed

Migrate to Sidekiq #198

artur-intech opened this issue Oct 5, 2016 · 9 comments

Comments

@artur-intech
Copy link
Contributor

artur-intech commented Oct 5, 2016

  • Check if it supports keyword arguments in jobs
  • Use Rails adapter (ActiveJob)

que gem's drawbacks:

@artur-intech artur-intech changed the title Consider switching to sidekiq Migrate to sidekiq Feb 24, 2018
@artur-intech artur-intech changed the title Migrate to sidekiq Migrate to Sidekiq Feb 24, 2018
@teadur
Copy link
Contributor

teadur commented Mar 11, 2018

@artur-beljajev the first drawback link is broken.
It seems 1.0.0b does support activejob

To we have any other drawbacks ?

@artur-intech
Copy link
Contributor Author

artur-intech commented Apr 2, 2018

sidekiq is the de facto standard. It is more sophisticated. It uses nosql to manage jobs, which is more efficient. It's really well supported. que has 386k downloads, whereas sidekiq has 22M. It is therefore easier to support it.

@artur-intech
Copy link
Contributor Author

artur-intech commented Apr 7, 2018

@vohmar We could start migration step by step

@maciej-szlosarczyk
Copy link
Contributor

Migrating to sidekiq introduces redis server which needs is an architecture component that needs to be monitored, managed and updated. This is not really a decision we can make without considering the ops part of it.

@maciej-szlosarczyk
Copy link
Contributor

We might be better off with moving to delayed_job instead, which supports postgres as the queue backend.

https://github.com/collectiveidea/delayed_job

@artur-intech
Copy link
Contributor Author

artur-intech commented Jun 26, 2018

https://github.com/collectiveidea/delayed_job/blob/master/CHANGELOG.md seems kinda abondoned as well. sidekiq is considered de facto standard these days.

@maciej-szlosarczyk
Copy link
Contributor

I'd say that strong second in popularity and 11 milion downloads is a good bet if maintaining Postgres as backend is one of our goals. At this point I have no reason to assume that it is not.

image

@teadur
Copy link
Contributor

teadur commented Jun 26, 2018

As of sidekiq would introduce new dependencies to application stack, i would vote for delayed_job.

@artur-intech
Copy link
Contributor Author

artur-intech commented Jun 19, 2019

Decided to move to delayed_job.

Closed in favor of #1234.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants