Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace que_mailer #895

Closed
maciej-szlosarczyk opened this issue Jun 26, 2018 · 0 comments · Fixed by #1163
Closed

Replace que_mailer #895

maciej-szlosarczyk opened this issue Jun 26, 2018 · 0 comments · Fixed by #1163
Assignees
@vohmar
Labels
enhancement

Comments

@maciej-szlosarczyk
Copy link
Contributor

We need to migrate away from que_mailer gem. It has not been updated since 2014, can be considered effectively abandoned. The test suite does not run on Ruby 2.5 due to deprecation warnings.

/Users/maciej/.rvm/gems/ruby-2.5.0@que_mailer/gems/activesupport-4.0.13/lib/active_support/core_ext/numeric/conversions.rb:121: warning: constant ::Fixnum is deprecated
/Users/maciej/.rvm/gems/ruby-2.5.0@que_mailer/gems/activesupport-4.0.13/lib/active_support/core_ext/numeric/conversions.rb:121: warning: constant ::Bignum is deprecated
Traceback (most recent call last):
	5470: from /Users/maciej/.rvm/gems/ruby-2.5.0@que_mailer/bin/ruby_executable_hooks:15:in `<main>'
	5469: from /Users/maciej/.rvm/gems/ruby-2.5.0@que_mailer/bin/ruby_executable_hooks:15:in `eval'
	5468: from /Users/maciej/.rvm/gems/ruby-2.5.0@que_mailer/bin/rspec:23:in `<main>'
	5467: from /Users/maciej/.rvm/gems/ruby-2.5.0@que_mailer/bin/rspec:23:in `load'
	5466: from /Users/maciej/.rvm/gems/ruby-2.5.0@que_mailer/gems/rspec-core-3.7.1/exe/rspec:4:in `<top (required)>'
	5465: from /Users/maciej/.rvm/gems/ruby-2.5.0@que_mailer/gems/rspec-core-3.7.1/lib/rspec/core/runner.rb:45:in `invoke'
	5464: from /Users/maciej/.rvm/gems/ruby-2.5.0@que_mailer/gems/rspec-core-3.7.1/lib/rspec/core/runner.rb:71:in `run'
	5463: from /Users/maciej/.rvm/gems/ruby-2.5.0@que_mailer/gems/rspec-core-3.7.1/lib/rspec/core/runner.rb:86:in `run'
	 ... 5458 levels...
	   4: from /Users/maciej/.rvm/gems/ruby-2.5.0@que_mailer/gems/activesupport-4.0.13/lib/active_support/core_ext/numeric/conversions.rb:131:in `block (2 levels) in <class:Numeric>'
	   3: from /Users/maciej/.rvm/gems/ruby-2.5.0@que_mailer/gems/activesupport-4.0.13/lib/active_support/core_ext/numeric/conversions.rb:131:in `block (2 levels) in <class:Numeric>'
	   2: from /Users/maciej/.rvm/gems/ruby-2.5.0@que_mailer/gems/activesupport-4.0.13/lib/active_support/core_ext/numeric/conversions.rb:131:in `block (2 levels) in <class:Numeric>'
	   1: from /Users/maciej/.rvm/gems/ruby-2.5.0@que_mailer/gems/activesupport-4.0.13/lib/active_support/core_ext/numeric/conversions.rb:131:in `block (2 levels) in <class:Numeric>'
/Users/maciej/.rvm/gems/ruby-2.5.0@que_mailer/gems/activesupport-4.0.13/lib/active_support/core_ext/numeric/conversions.rb:131:in `block (2 levels) in <class:Numeric>': stack level too deep (SystemStackError)

Blocks #546 , #377. Ties in nicely with #198 if we were to move to delayed_job (or any other que that supports postgres as its backend)
This was referenced Jun 26, 2018
Open
Closed
@artur-intech artur-intech self-assigned this Mar 1, 2019
artur-intech pushed a commit that referenced this issue Apr 7, 2019
Do not use Que::Mailer in InvoiceMailer
d71c28f 
It's also impossible to test mailer otherwise. It fails with:
> NoMethodError: undefined method `deliver_now'

#895
artur-intech pushed a commit that referenced this issue Apr 7, 2019
Do not use Que::Mailer in InvoiceMailer
070c9e5 
#895
artur-intech pushed a commit that referenced this issue Apr 10, 2019
Do not use Que::Mailer in InvoiceMailer
34bb364 
#895
artur-intech pushed a commit that referenced this issue Apr 10, 2019
Refactor invoice delivery
60cabbb 
- Remove `Que::Mailer` (#895)
- Extract controller
- Convert HAML to ERB
- Add mailer preview
- Improve UI
- Add tests
@artur-intech artur-intech mentioned this issue Apr 10, 2019
Merged
artur-intech pushed a commit that referenced this issue Apr 10, 2019
Refactor invoice delivery
05f02e3 
- Remove `Que::Mailer` (#895)
- Extract controller
- Extract translations
- Convert HAML to ERB
- Add mailer preview
- Improve UI
- Add tests
artur-intech pushed a commit that referenced this issue Apr 10, 2019
Refactor invoice PDF generation, download and delivery
d310ee3 
- Remove `Que::Mailer` (#895)
- Extract controllers
- Extract translations
- Convert HAML to ERB
- Add mailer preview
- Improve UI
- Remove unused routes
- Add tests
artur-intech pushed a commit that referenced this issue Apr 10, 2019
Refactor invoice PDF generation, download and delivery
64c56b9 
- Remove `Que::Mailer` (#895)
- Extract controllers
- Extract translations
- Convert HAML to ERB
- Add mailer preview
- Improve UI
- Remove unused routes
- Add tests
artur-intech pushed a commit that referenced this issue Apr 10, 2019
Refactor invoice PDF generation, download and delivery
b421226 
- Remove `Que::Mailer` (#895)
- Extract controllers
- Extract translations
- Convert HAML to ERB
- Add mailer preview
- Improve UI
- Remove unused routes
- Add tests
artur-intech pushed a commit that referenced this issue Apr 10, 2019
Refactor invoice PDF generation, download and delivery
97dd5b4 
- Remove `Que::Mailer` (#895)
- Extract controllers
- Extract translations
- Convert HAML to ERB
- Add mailer preview
- Improve UI
- Remove unused routes
- Add tests
artur-intech pushed a commit that referenced this issue Apr 11, 2019
Refactor invoice PDF generation, download and delivery
27ea790 
- Remove `Que::Mailer` (#895)
- Extract controllers
- Extract translations
- Convert HAML to ERB
- Add mailer preview
- Improve UI
- Remove unused routes
- Add tests
artur-intech pushed a commit that referenced this issue Apr 11, 2019
Remove Que::Mailer (#895)
d2880bd
artur-intech pushed a commit that referenced this issue Apr 11, 2019
Refactor contact mailer
5674071 
- Send single email with new email in `to` and old email in `bcc` fields
- Remove `Que::Mailer` (#895)
- Add preview
- DRY templates
- Add tests
- Extract translations
- Remove useless specs
@artur-intech artur-intech mentioned this issue Apr 11, 2019
Merged
artur-intech pushed a commit that referenced this issue Apr 12, 2019
Remove Que::Mailer
425fb27 
#895
artur-intech pushed a commit that referenced this issue Apr 12, 2019
Remove que_mailer gem
9cd1b14 
Closes #895
@artur-intech artur-intech mentioned this issue Apr 12, 2019
Merged
@artur-intech artur-intech mentioned this issue Apr 14, 2019
Merged
artur-intech pushed a commit that referenced this issue Apr 14, 2019
Refactor domain mailer
a64726a 
- Remove `Que::Mailer` (#895)
- Add preview
- DRY templates
- Add tests
- Extract translations
artur-intech pushed a commit that referenced this issue Apr 14, 2019
Refactor domain mailer
719c46c 
- Remove `Que::Mailer` (#895)
- Add preview
- DRY templates
- Add tests
- Extract translations
@artur-intech artur-intech assigned vohmar and unassigned artur-intech Apr 14, 2019
artur-intech pushed a commit that referenced this issue Apr 14, 2019
Refactor domain mailer
072ba42 
- Remove `Que::Mailer` (#895)
- Add preview
- DRY templates
- Add tests
- Extract translations
artur-intech pushed a commit that referenced this issue Apr 19, 2019
Refactor domain mailer
4b91cf9 
- Remove `Que::Mailer` (#895)
- Add preview
- DRY templates
- Add tests
- Extract translations
artur-intech pushed a commit that referenced this issue Apr 23, 2019
Remove que_mailer gem
a5fa78e 
Closes #895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vohmar vohmar

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove que_mailer gem internetee/registry
3 participants
@maciej-szlosarczyk @vohmar @artur-intech