Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated errors message if hostname response to A/AAAA records #2610

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −9
Open

updated errors message if hostname response to A/AAAA records #2610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bedf36
updated errors message if hostname response to A/AAAA records
OlegPhenomenon Aug 28, 2023
c70a1e8
refactored
OlegPhenomenon Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,9 @@ group :test do
gem 'database_cleaner'
gem 'minitest', '~> 5.17'
gem 'minitest-stub_any_instance'
gem 'selenium-webdriver'
gem 'simplecov', '0.17.1', require: false # CC last supported v0.17
gem 'spy'
gem 'webdrivers'
gem 'webmock'
end

Expand Down
8 changes: 2 additions & 6 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,10 +513,6 @@ GEM
addressable
httpi (~> 2.0)
nokogiri (>= 1.4.2)
webdrivers (4.6.1)
nokogiri (~> 1.6)
rubyzip (>= 1.3.0)
selenium-webdriver (>= 3.0, < 4.0)
webfinger (1.2.0)
activesupport
httpclient (>= 2.4)
Expand Down Expand Up @@ -594,6 +590,7 @@ DEPENDENCIES
sass-rails
select2-rails (= 4.0.13)
selectize-rails (= 0.12.6)
selenium-webdriver
sidekiq (~> 7.0)
simplecov (= 0.17.1)
simpleidn (= 0.2.1)
Expand All @@ -602,10 +599,9 @@ DEPENDENCIES
truemail (~> 3.0)
uglifier
validates_email_format_of (= 1.7.2)
webdrivers
webmock
whenever (= 1.0.0)
wkhtmltopdf-binary (~> 0.12.6.1)

BUNDLED WITH
2.4.14
2.4.19
5 changes: 4 additions & 1 deletion app/interactions/actions/email_check.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,10 @@ def handle_mx_validation(result)
output_a_and_aaaa_validation_results(email: email, result: result_validation, type: 'AAAA')
end

result.success = result_validation.present?
return if result_validation.blank?

result.success = true
result.errors.merge!({ mx: 'target host(s) not found, but was able to find A/AAAA records for domain' })
end

def handle_saving_result(contact, result)
Expand Down
1 change: 0 additions & 1 deletion test/application_system_test_case.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class ApplicationSystemTestCase < ActionDispatch::IntegrationTest
class JavaScriptApplicationSystemTestCase < ApplicationSystemTestCase
self.use_transactional_tests = false
DatabaseCleaner.strategy = :truncation
Webdrivers::Chromedriver.required_version = '114.0.5735.90'

Capybara.register_driver(:chrome) do |app|
options = ::Selenium::WebDriver::Chrome::Options.new
Expand Down