Update company_register gem and fix logger dependency #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch company_register gem to 'issues-with-upcoming-data' branch - Add concurrent-ruby 1.3.4 to fix ThreadSafeLevel logger error - Update various gem dependencies Resolves logger initialization error related to ActiveSupport::Logger::ThreadSafeLevel
- Replace RegistrantUser.find_by with Contact model query - Add proper scoping for organization contacts from Estonia - Include join with registrant domains This ensures consistent contact lookup between bulk and single checker methods
- Add OrgRegistrantPhoneCheckerJob execution for contact creation and update - Rename validate_* methods to maybe_validate_* for consistency - Add tests for phone number validation in REPP API - Fix method naming and add proper job arguments This ensures phone numbers are validated against company register data for Estonian organization contacts after creation or update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #internetee/rest-whois#416
Resolves logger initialization error related to ActiveSupport::Logger::ThreadSafeLevel