Add error handling for suggest subdomains

dashboard/internet_nl_dashboard/logic/domains.py

@@ -34,7 +34,7 @@ def suggest_subdomains(domain: str, period: int = 370):
 
     # ip address or garbage
     if not extract.domain or not extract.suffix:
-        return []
+        raise ValueError("Invalid input")
 
     # call SUBDOMAIN_SUGGESTION_SERVER_ADDRESS
     response = requests.get(config.SUBDOMAIN_SUGGESTION_SERVER_ADDRESS,
@@ -43,7 +43,7 @@ def suggest_subdomains(domain: str, period: int = 370):
 
     if response.status_code != 200:
         log.error("Failed to retrieve subdomain suggestions from  %s.", config.SUBDOMAIN_SUGGESTION_SERVER_ADDRESS)
-        return []
+        raise Exception("Failed to retrieve subdomain suggestions")
 
     return response.json()
 

dashboard/internet_nl_dashboard/views/domains.py

@@ -2,7 +2,7 @@
 from typing import List
 
 from django.contrib.auth.decorators import login_required
-from django.http import JsonResponse
+from django.http import HttpResponseBadRequest, HttpResponseServerError, JsonResponse
 from django.views.decorators.http import require_http_methods
 from websecmap.app.common import JSEncoder
 
@@ -20,7 +20,14 @@ def suggest_subdomains_(request) -> JsonResponse:
     request = get_json_body(request)
     domain = request.get("domain", "")
     period = request.get("period", 370)
-    return JsonResponse(suggest_subdomains(domain, period), encoder=JSEncoder, safe=False)
+    try:
+        result = JsonResponse(suggest_subdomains(domain, period), encoder=JSEncoder, safe=False)
+    except ValueError as e:
+        result = HttpResponseBadRequest(str(e))
+    except Exception:
+        result = HttpResponseServerError("Error occured while getting subdomain suggestions")
+
+    return result
 
 
 @login_required(login_url=LOGIN_URL)

dashboard/settings.py

@@ -9,9 +9,8 @@
 from sentry_sdk.integrations.redis import RedisIntegration
 
 from . import __version__
+from .settings_constance import CONSTANCE_ADDITIONAL_FIELDS  # noqa  # pylint: disable=unused-import
 from .settings_constance import CONSTANCE_CONFIG_FIELDSETS  # noqa pylint: disable=unused-import
-from .settings_constance import (CONSTANCE_ADDITIONAL_FIELDS,  # noqa  # pylint: disable=unused-import
-                                 CONSTANCE_BACKEND, CONSTANCE_CONFIG)
 # import all of this and don't auto-lint it away because there are no references here.
 # most code refers to these settings.
 from .settings_jet import JET_SIDE_MENU_COMPACT, JET_SIDE_MENU_ITEMS  # noqa  # pylint: disable=unused-import