-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sectxt to 0.9.0 #1046
Comments
I'll find out which new content labels we need. |
DigitalTrustCenter/sectxt#65 is a blocker for this |
Content still needs to be checked: all labels in https://github.com/DigitalTrustCenter/sectxt/ readme need to be in our content too. |
Crappy one-liner check (formatted on 3 lines for readability 😅): $ diff \
<(grep -oP '"\K[a-z0-9]+_[a-z0-9_]+(?=")' sectxt/sectxt/__init__.py | sort -u) \
<(ls internet.nl_content/detail/tech/data/http-securitytxt/ | sed 's/_..\.md$//g' | sort -u) 1d0
< bom_in_file
5,6c4
< field_name
< invalid_cert
---
> expired
12c10
< invalid_uri_scheme
---
> location
26c24,25
< no_security_txt
---
> no_security_txt_404
> no_security_txt_other
31d29
< pgp_envelope
33a32,33
> requested-from
> retrieved-from
35a36
> utf8 At least for sure currently these are missing:
At a manual inspection of sectxt I however see that |
Upstream solved it in the 0.9.3 release. |
Although this is in milestone v1.9, it is already included and deployed in the 'batch' release v1.8.7. |
@bwbroersma I just copied the English texts from https://github.com/DigitalTrustCenter/sectxt/blob/main/README.md to new text files for:
I will check these texts and translate them into Dutch. Couldn't find |
Changed and translated texts for:
Made a note in the |
|
@mxsasha Double-checking with you:
|
I think it's best to close this issue (as solved for v1.9) and fix these minor edge cases another release. |
Ok, thanks! Agreed. Still two questions:
|
|
Ad 1: I left the respective text files in the content repo, and added the following note to each of them: [Note: this content label is currently not used. See #1046.] |
DigitalTrustCenter/sectxt released 0.9.0 with has quite a few parser improvements, especially on PGP.
The only one I'm not sure about is the stripping of the BOM (DigitalTrustCenter/sectxt#57 (comment)). I interpret the RFC 9116 - File Format Description and ABNF Grammar:
RFC 5198 states:
Especially in combination with signing maybe a⚠️ warning or ℹ️ notice should be shown. Although it's outside of the PGP block, a file with BOM is no longer recognized with
file
in Linux as a PGP signed file.The text was updated successfully, but these errors were encountered: