Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weigh RPKI test results in overall score #745

Open
baknu opened this issue Sep 1, 2022 · 11 comments · Fixed by #1003
Open

Weigh RPKI test results in overall score #745

baknu opened this issue Sep 1, 2022 · 11 comments · Fixed by #1003
Assignees
Labels
content enhancement release blocker Issues that must be resolved before an upcoming version can be released
Milestone

Comments

@baknu
Copy link
Contributor

baknu commented Sep 1, 2022

No description provided.

@baknu baknu added this to the v1.6 milestone Sep 1, 2022
@mxsasha mxsasha modified the milestones: v1.7, v1.8 Oct 20, 2022
@baknu
Copy link
Contributor Author

baknu commented Apr 6, 2023

This would also be in line with the recente mandate for governments to implement RPKI: https://forumstandaardisatie.nl/nieuws/secured-internet-routing-dutch-government-end-2024

@mxsasha mxsasha added discuss Requires further team discussion and decisions and removed discuss Requires further team discussion and decisions labels Apr 27, 2023
@baknu
Copy link
Contributor Author

baknu commented May 19, 2023

@dennisbaaten Could you check if all hosters in our HoF for Hosters are passing the RPKI test? And could you give the hosters in the list a headsup ons this upcoming change?

@mxsasha
Copy link
Collaborator

mxsasha commented Jun 15, 2023

Did we make a decision on the degree of score impact? The math is quite opaque, but I have a working implementation for web where the total score impact is 87% when a domain fails RPKI validity for web and NS, succeeding all other (scoring) tests including RPKI existence. We can lower the score impact.

@mxsasha mxsasha added the discuss Requires further team discussion and decisions label Jun 15, 2023
@mxsasha mxsasha linked a pull request Jun 16, 2023 that will close this issue
@baknu baknu modified the milestones: v1.8, v1.9 Sep 5, 2023
@AZ-DPC-OA-DNR
Copy link

Good to see progress on this improvement! RPKI and security.txt often fly under the radar, without any impact on the test scores.

Will the impact for a mailserver failing RPKI in the mail test be the same as for a webserver in the web test? If so, what will be the score if the nameservers do support RPKI correctly and other (scoring) tests are also ok?

JvB

@bwbroersma
Copy link
Collaborator

I noticed there is a wide understanding that a 100%-score on internet.nl means all Dutch government standard requirements are met. This was true before RPKI was made a 'streefbeeldafspraak'. I think this issue therefor this is a important issue to deploy the fix - PR #1003 soon.

@mxsasha: do I read 97d1249 correctly that this is an 0 or full score, not like with DNSSEC that RPKI not-found gives some points, right? (I thought it was 100 / number of test blocks, is RPKI the first exception on this or was it already not equally divided in terms of points?)

@AZ-DPC-OA-DNR: in general, the total points for a test block are divided by the number of sub tests, for RPKI there are 3 for e-mail, and 2 for web. If 13 points are to be divided, I think it would be 6.5 per sub test in the web test and 4.33 per sub test in the e-mail test.

@AZ-DPC-OA-DNR
Copy link

@bwbroersma Thanks for your explanation & efforts to get related PR #1003 deployed for RPKI.

I agree this is essential to improve compliancy with security standards on NL government domains, where RPKI is mandatory on all domains (and security.txt for web services).

JvB

@mxsasha
Copy link
Collaborator

mxsasha commented Dec 5, 2023

Did we make a decision on the degree of score impact? The math is quite opaque, but I have a working implementation for web where the total score impact is 87% when a domain fails RPKI validity for web and NS, succeeding all other (scoring) tests. We can lower the score impact.

The score calculation is now documented: https://github.com/internetstandards/Internet.nl/blob/main/documentation/scoring.md

This is consistent with what I saw with #1003, though it does mean the impact can not be changed. The only variation we can make is whether individual subtests are more important than others, e.g. should validity count more than existence. But that applies within the RPKI category only - the impact of "all failed" vs "all success" is fixed. We can change "all existence failed, rest succeeded" vs "all validy failed, rest succeeded" a bit.

@mxsasha
Copy link
Collaborator

mxsasha commented Dec 12, 2023

Decision: RPKI existence will count for HALF_WEIGHT_POINTS, RPKI validity for FULL_WEIGHT_POINTS.

@baknu
Copy link
Contributor Author

baknu commented Jan 9, 2024

Content:

@mxsasha
Copy link
Collaborator

mxsasha commented Mar 7, 2024

This is merged, but content still needs to be updated. That makes this content update a blocker for eventual 1.9

@mxsasha mxsasha reopened this Mar 7, 2024
@mxsasha mxsasha removed their assignment Mar 7, 2024
@mxsasha mxsasha removed the discuss Requires further team discussion and decisions label Mar 7, 2024
@mxsasha mxsasha added the release blocker Issues that must be resolved before an upcoming version can be released label Apr 2, 2024
@baknu
Copy link
Contributor Author

baknu commented May 16, 2024

Note: Make sure to also update content on /faqs/report/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content enhancement release blocker Issues that must be resolved before an upcoming version can be released
Development

Successfully merging a pull request may close this issue.

4 participants