Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove not needed CSRF token #1582

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Remove not needed CSRF token #1582

merged 2 commits into from
Jan 28, 2025

Conversation

bwbroersma
Copy link
Collaborator

For /change_language/ the result is only a Location redirect (no session/cookie state), therefore there is no need for a CRSF token.

@bwbroersma bwbroersma force-pushed the gh1582-remove-not-needed-csrf-token branch 6 times, most recently from f736c91 to e220687 Compare December 9, 2024 21:47
@bwbroersma
Copy link
Collaborator Author

Note: do not remove "django.middleware.common.CommonMiddleware", which I over actively stripped, and somehow process_response does essential work in either fixing missing slashes, or setting a Content-Length.

@mxsasha mxsasha changed the title Remove not needed CSRF token [hold for 1.9 fork] Remove not needed CSRF token Jan 10, 2025
@mxsasha mxsasha added this to the v1.10 milestone Jan 22, 2025
@mxsasha mxsasha changed the title [hold for 1.9 fork] Remove not needed CSRF token Remove not needed CSRF token Jan 28, 2025
@bwbroersma @mxsasha
Remove not needed CSRF token
c270dcd 
For `/change_language/` the result is only a Location redirect (no session/cookie state), therefore there is no need for a CRSF token.
Fix internetstandards#1581.

Signed-off-by: Benjamin W. Broersma <bw@broersma.com>
@bwbroersma @mxsasha
Remove unused django.contrib admin, auth, sessions and messages middl…
93acd30 
…eware
@mxsasha mxsasha force-pushed the gh1582-remove-not-needed-csrf-token branch from e220687 to 93acd30 Compare January 28, 2025 16:54
@mxsasha mxsasha merged commit 0a16ff7 into internetstandards:main Jan 28, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

csrfmiddlewaretoken send but not used
2 participants
@bwbroersma @mxsasha