[_] fix: added future iat to new tokens issued on password change #406
+146
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apsantiso
had a problem deploying
to
development
GitHub Actions
Failure
apsantiso
force-pushed
the
fix/return-tokens-on-password-change
branch
from
b5beb4a
to
93cf7c9
Compare
apsantiso
had a problem deploying
to
development
GitHub Actions
Failure
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/middlewares/passsword.spec.ts
Dismissed
| } from './passport'; | ||
|
|
||
| describe('JWT Utility Functions', () => { | ||
| const secret = 'test_secret'; |
Check failure
Code scanning / CodeQL
Hard-coded credentials Critical test
There was a problem hiding this comment.
Used in tests, dismissed this issue.
apsantiso
force-pushed
the
fix/return-tokens-on-password-change
branch
from
93cf7c9
to
3236f07
Compare
apsantiso
had a problem deploying
to
development
GitHub Actions
Failure
|
apsantiso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Token's IAT do not include milliseconds, so we create new tokens with an IAT 60 seconds ahead so they are valid when compared against
lastPasswordChangedAtvalue.This is the same implementation we have on drive-server, I'm just migrating it.