Feature/playwright e2e tests #1233

savilashokworks · 2024-08-14T19:59:00Z

The login tests were improved although they still need the env values for the user and pass.
The signup tests are being developed.

…locators, pages and specs. The firsts tests about the LOGIN feature are still in progress

…needs to add env variables for user and password

vercel · 2024-08-14T19:59:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
drive-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 18, 2024 2:56pm

…d. The setup file was created in order to log in automatically for tests that require logging in. The setup was configured for chrome, firefox and Safari

cloudflare-workers-and-pages · 2024-08-15T20:25:58Z

Deploying drive-web with Cloudflare Pages

Latest commit:	`f0ddcf6`
Status:	⚡️ Build in progress...

View logs

CandelR

Good work @savilashokworks. This is looking good.

CandelR · 2024-09-03T12:59:20Z

tests/helper/staticData.ts

+  email: 'testingb2b@inxt.com',
+  password: 'test123.',


Maybe we could make part of the email dynamic, so that each time the signup is tested as well

Ramon!! Yes, it makes perfect sense and I should've done that way! Great, I'll include it in my next commit ;)

CandelR · 2024-09-03T13:10:00Z

tests/specs/login.setup.ts

+import { loginPage } from '../pages/loginPage';
+import { staticData } from '../helper/staticData';
+
+const authFile = './tests/specs/playwright/.auth/user.json';


Have you tried to automate the login for each test so you don't have to have the user data in a file?
This may limit some days to do tests, because apart from putting sensitive data of the user in question, it will be filled with test data when uploading files or folders and perform certain actions.
This together with the dynamic email and the sign up, you will be able to test each run with an independent user.
Let me know if I miss anything 😄

Let me know if I'm right. You want to log in before each test (no matter if the tests include "log in" tests or not) ❓

In that case, I think I still need the login.setup.ts so as to create the user, log in and save the cookies (that's what it's meant to do). Then I can just ignore the cookies stored and log in in a before hook. I would still need to figure out how to pass the credentials into the tests without revealing data, is that right?

But the setup.ts speeds the whole testing up by using the cookies instead of logging in "manually", that's the benefit of it, but if you're ok with logging in before each test, it can be done, definitely. Unless you want to get rid of the setup.ts D:

tests/locators/driveLocators.ts

… playwright locators

…ernxt/drive-web into feature/playwright-e2e-tests

… All the test should pass in all browsers

sonarcloud · 2024-09-23T19:58:27Z

Quality Gate failed

Failed conditions
6.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

CandelR · 2024-09-30T09:51:30Z

tests/specs/playwright/.auth/credentials.json

@@ -0,0 +1 @@
+{"email":"Art.Goyette77@yahoo.com","password":"whSneqH707MPwbp"}


Be careful when exposing sensitive data such as username/password. The user has to be dynamic in every test.
With cypress we wrote the generated user and password dynamically in a json so that after registering the user, the other tests could use the login and re-run the test

…n was added

CandelR · 2024-11-15T07:40:37Z

tests/pages/drivePage.ts

    await this.page.locator('body').click({ button: 'right' });
+    await this.page.waitForTimeout(500);
+    //await expect(this.rightClickOnBodyModal).toBeVisible()


forgot to remove this commeted line.

CandelR · 2024-11-15T07:41:27Z

tests/pages/loginPage.ts

-    const createAccountTitle = await this.createAccounTitle.textContent();
+    await expect(this.createAccounTitle).toBeVisible();
+    const createAccountHeader = this.createAccounTitle.textContent();
+    //console.log(createAccountHeader)


forgot to remove this commented log.

CandelR · 2024-11-15T08:37:41Z

playwright.config.ts

@@ -27,7 +29,7 @@ export default defineConfig({
  /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
  use: {
    /* Base URL to use in actions like `await page.goto('/')`. */
-    baseURL: 'https://staging.drive.internxt.com/login',
+    baseURL: 'https://drive.internxt.com/login',


You need to run the test with the current branch in a local environment, not pointing to the production frontend, the backend could be the production one but not the frontend.
If you point to the production frontend you are not testing the actual changes.

CandelR · 2024-11-15T08:38:45Z

tests/helper/staticData.ts

  passwordRecoveryLinkURL: 'https://drive.internxt.com/recovery-link/',
  signUpURL: 'https://drive.internxt.com/new',
-  driveURL: 'https://staging.drive.internxt.com/',
+  driveURL: 'https://drive.internxt.com/',


Better add a constant with the baseURL and reuse it everywhere, otherwise it's going to be a hassle if you have to add any changes.

CandelR · 2024-11-15T08:42:58Z

tests/specs/login.setup.ts

  await expect(newPage).toHaveURL(/.*login/);

-  const endpointPromise = newPage.waitForResponse('https://drive.internxt.com/api/access');
+  //const endpointPromise = newPage.waitForResponse('https://drive.internxt.com/api/access');
+  const endpointPromise = newPage.waitForResponse('https://gateway.internxt.com/drive-old/access');


Add all the urls to constants

CandelR · 2024-11-15T08:43:10Z

tests/specs/login.setup.ts

@@ -36,10 +36,11 @@ setup('Creating new user and logging in', async ({ browser }) => {

  const loginpage = new loginPage(newPage);

-  await newPage.goto('https://staging.drive.internxt.com/login');
+  await newPage.goto('https://drive.internxt.com/login');


same here, use a constnat for urls

CandelR · 2024-11-15T08:46:55Z

tests/specs/login.setup.ts


-  await page.goto('https://staging.drive.internxt.com/new');
+  await page.goto('https://drive.internxt.com/new');


remember to use the constnat for urls and point to local environment

QAZebass added 2 commits August 9, 2024 16:51

The first commit contains the creation of the folders: data, helper, …

3079e25

…locators, pages and specs. The firsts tests about the LOGIN feature are still in progress

login tests was updated and sign up tests are being developed. Still …

51c4bb0

…needs to add env variables for user and password

savilashokworks requested a review from CandelR as a code owner August 14, 2024 19:59

vercel bot deployed to Preview August 14, 2024 20:00 View deployment

github-actions bot added the ready-for-preview label Aug 14, 2024

existing tests were refined. The folder creation tests was initialize…

68cb6de

…d. The setup file was created in order to log in automatically for tests that require logging in. The setup was configured for chrome, firefox and Safari

vercel bot deployed to Preview August 15, 2024 20:28 View deployment

CandelR reviewed Sep 3, 2024

View reviewed changes

faker.js installed. Locators folder deleted for simplicity and use of…

568f4d6

… playwright locators

vercel bot deployed to Preview September 9, 2024 20:06 View deployment

fixed tests that depended on locators folder

a176dc5

vercel bot deployed to Preview September 9, 2024 21:40 View deployment

Hide banner in development mode

c5f6cf6

vercel bot deployed to Preview September 11, 2024 15:12 View deployment

QAZebass added 2 commits September 12, 2024 15:40

Dinamyc new user per test run was added

2a8096f

Merge branch 'feature/playwright-e2e-tests' of https://github.com/int…

a7f3d94

…ernxt/drive-web into feature/playwright-e2e-tests

vercel bot deployed to Preview September 12, 2024 18:44 View deployment

BasePage deleted, Edge browser project configured, flaky tests fixed.…

25b5ed4

… All the test should pass in all browsers

vercel bot deployed to Preview September 19, 2024 02:25 View deployment

unnecessary waits deleted, credentials passed through credentials.json

5b3fc8c

vercel bot deployed to Preview September 23, 2024 19:59 View deployment

CandelR reviewed Sep 30, 2024

View reviewed changes

Locators, staticdata, upload folder and first test about file deletio…

dbfbe8d

…n was added

vercel bot deployed to Preview November 13, 2024 20:06 View deployment

Ramon Candel added 2 commits November 15, 2024 08:54

Added staging env for playwright tests

58b4951

Merge branch 'master' into feature/playwright-e2e-tests

1862a2e

vercel bot deployed to Preview November 15, 2024 08:00 View deployment

Add required node version to playwright action

860bf7e

vercel bot deployed to Preview November 15, 2024 08:05 View deployment

CandelR requested changes Nov 15, 2024

View reviewed changes

Run local front to run tests in local env

4692429

vercel bot deployed to Preview November 15, 2024 09:00 View deployment

Change on playwright ci to run dev server

2bd3c2c

vercel bot deployed to Preview November 15, 2024 09:21 View deployment

corrected login test url

0d60175

vercel bot deployed to Preview November 15, 2024 09:30 View deployment

Changed wait to wrong endpoint

670dbee

vercel bot deployed to Preview November 15, 2024 09:40 View deployment

Removed cypress test run from ci action

d513f84

vercel bot deployed to Preview November 15, 2024 09:46 View deployment

Diplay on boarding tutorial only in production environment

f0ddcf6

vercel bot deployed to Preview November 18, 2024 14:56 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/playwright e2e tests #1233

Feature/playwright e2e tests #1233

savilashokworks commented Aug 14, 2024

vercel bot commented Aug 14, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Aug 15, 2024 •

edited

Loading

CandelR left a comment

CandelR Sep 3, 2024

savilashokworks Oct 7, 2024

CandelR Sep 3, 2024

savilashokworks Oct 7, 2024 •

edited

Loading

sonarcloud bot commented Sep 23, 2024

CandelR Sep 30, 2024

CandelR Nov 15, 2024

CandelR Nov 15, 2024

CandelR Nov 15, 2024

CandelR Nov 15, 2024

CandelR Nov 15, 2024

CandelR Nov 15, 2024

CandelR Nov 15, 2024

		@@ -0,0 +1 @@
		{"email":"Art.Goyette77@yahoo.com","password":"whSneqH707MPwbp"}


		await page.goto('https://staging.drive.internxt.com/new');
		await page.goto('https://drive.internxt.com/new');

Feature/playwright e2e tests #1233

Are you sure you want to change the base?

Feature/playwright e2e tests #1233

Conversation

savilashokworks commented Aug 14, 2024

vercel bot commented Aug 14, 2024 • edited Loading

cloudflare-workers-and-pages bot commented Aug 15, 2024 • edited Loading

Deploying drive-web with Cloudflare Pages

CandelR left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

savilashokworks Oct 7, 2024 • edited Loading

Choose a reason for hiding this comment

sonarcloud bot commented Sep 23, 2024

Quality Gate failed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vercel bot commented Aug 14, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Aug 15, 2024 •

edited

Loading

savilashokworks Oct 7, 2024 •

edited

Loading