Revert back to the group serialization for ProtVer for PParams #3440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert back to the group serialization for ProtVer for PParams. This PR fixes the same problem with PParams serialization that was fixed in #3297, but it fixes in a slightly more backwards compatible manner. Namely it, as before #3297, unrolls ProtocolVersion into a list, except it properly adjusts the number of elements in the list.
Both Alonzo and Babbage PParams were affected and fixed in this PR.
Implementation in this PR was discussed here CardanoSolutions/ogmios#314 (comment)
Note the new version in the CHANGELOG, this is because this fix is getting backported to 1.2.1 versions in #3441
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)