fix: product variation availability if the products have more than 2 …

…variation attributes (#1613)
intershop · Mar 22, 2024 · 4e06b47 · 4e06b47
1 parent 59d15c6
commit 4e06b47
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 42 deletions.
diff --git a/src/app/core/models/product-variation/product-variation.helper.spec.ts b/src/app/core/models/product-variation/product-variation.helper.spec.ts
@@ -91,7 +91,7 @@ describe('Product Variation Helper', () => {
             "options": [
               {
                 "active": true,
-                "alternativeCombination": true,
+                "alternativeCombination": false,
                 "label": "A",
                 "metaData": undefined,
                 "type": "a1",
@@ -114,7 +114,7 @@ describe('Product Variation Helper', () => {
             "options": [
               {
                 "active": true,
-                "alternativeCombination": true,
+                "alternativeCombination": false,
                 "label": "A",
                 "metaData": undefined,
                 "type": "a2",
@@ -161,7 +161,7 @@ describe('Product Variation Helper', () => {
               },
               {
                 "active": true,
-                "alternativeCombination": true,
+                "alternativeCombination": false,
                 "label": "3",
                 "metaData": undefined,
                 "type": "a3",

diff --git a/src/app/core/models/product-variation/product-variation.helper.ts b/src/app/core/models/product-variation/product-variation.helper.ts
@@ -13,7 +13,7 @@ export class ProductVariationHelper {
    * Build select value structure
    */
   static buildVariationOptionGroups(product: ProductView): VariationOptionGroup[] {
-    if (!product) {
+    if (!product?.variableVariationAttributes?.length) {
       return [];
     }
 
@@ -126,53 +126,44 @@ export class ProductVariationHelper {
    * Check specific option if perfect variant match is not existing.
    *
    * @param option  The select option to check.
+   * @param product The given product containing the related product variations
    * @returns       Indicates if no perfect match is found.
    */
-  // eslint-disable-next-line complexity
   private static alternativeCombinationCheck(option: VariationSelectOption, product: ProductView): boolean {
     if (!product.variableVariationAttributes?.length) {
       return;
     }
 
-    let quality: number;
-    const perfectMatchQuality = product.variableVariationAttributes.length;
-
-    // loop all selected product attributes ignoring the ones related to currently checked option.
-    for (const selectedAttribute of product.variableVariationAttributes) {
-      // loop all possible variations
-      for (const variation of product.variations) {
-        quality = 0;
-
-        // loop attributes of possible variation.
-        for (const attribute of variation.variableVariationAttributes) {
-          // increment quality if variation attribute matches selected product attribute.
-          if (
-            attribute.variationAttributeId === selectedAttribute.variationAttributeId &&
-            ProductVariationHelper.isEqual(attribute.value, selectedAttribute.value)
-          ) {
-            quality += 1;
-            continue;
-          }
-
-          // increment quality if variation attribute matches currently checked option.
-          if (
-            attribute.variationAttributeId === option.type &&
-            ProductVariationHelper.isEqual(attribute.value, option.value)
-          ) {
-            quality += 1;
-            continue;
-          }
-        }
-
-        // perfect match found
-        if (quality === perfectMatchQuality) {
-          return false;
-        }
-      }
+    const comparisonAttributes = product.variableVariationAttributes.map(attribute =>
+      attribute.variationAttributeId === option.type ? { ...attribute, value: option.value } : attribute
+    );
+
+    // check if the current product has the same attributes as the attributes to be compared
+    if (
+      ProductVariationHelper.variationAttributeArrayEquals(product.variableVariationAttributes, comparisonAttributes)
+    ) {
+      // perfect match found
+      return false;
     }
 
-    // imperfect match
-    return true;
+    // check if one of the variation products has the same attributes as the attributes to be compared
+    return !product.variations.some(variation =>
+      ProductVariationHelper.variationAttributeArrayEquals(variation.variableVariationAttributes, comparisonAttributes)
+    );
+  }
+
+  // determines whether both arrays have the same variation attributes
+  private static variationAttributeArrayEquals(array1: VariationAttribute[], array2: VariationAttribute[]): boolean {
+    return (
+      Array.isArray(array1) &&
+      Array.isArray(array2) &&
+      array1.length === array2.length &&
+      array1.every(val =>
+        array2.find(
+          attribute => attribute.name === val.name && ProductVariationHelper.isEqual(attribute.value, val.value)
+        )
+      )
+    );
   }
 
   private static toValue(input: VariationAttribute['value']): string | number {