Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: product variation availability for more than 2 variation attributes combinations #1613

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Mar 20, 2024

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

If a product has more than 2 variation attributes in the variation select options all options are displayed as not available.

Issue Number: Closes #

What Is the New Behavior?

The calculation of the variation availabilty works now properly and only attribute (combinations) that are not available are shown as not available.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#94629
AB#95151

@SGrueber SGrueber requested a review from shauke March 20, 2024 10:25
@SGrueber SGrueber self-assigned this Mar 20, 2024
@SGrueber SGrueber added the bug Something isn't working label Mar 20, 2024
@SGrueber SGrueber added this to the 5.1 milestone Mar 20, 2024
Copy link

Azure Demo Servers are available:

@SGrueber SGrueber force-pushed the bugfix/variation_availability branch 3 times, most recently from d58375c to 399441b Compare March 22, 2024 10:48
* if the products have more than 2 variation attributes
@shauke shauke force-pushed the bugfix/variation_availability branch from 399441b to bbea504 Compare March 22, 2024 16:28
@shauke shauke changed the title fix: variation availability display fix: product variation availability for more than 2 variation attributes combinations Mar 22, 2024
@shauke shauke merged commit 4e06b47 into develop Mar 22, 2024
13 checks passed
@shauke shauke deleted the bugfix/variation_availability branch March 22, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working has conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants