fix: data type of some creation dates (#1582)

intershop · Jan 31, 2024 · 7e6c02c · 7e6c02c
1 parent 88de2a2
commit 7e6c02c
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 9 deletions.
diff --git a/src/app/core/models/cost-center/cost-center.interface.ts b/src/app/core/models/cost-center/cost-center.interface.ts
@@ -6,7 +6,7 @@ import { CostCenter } from './cost-center.model';
 export type CostCenterData = Omit<CostCenter, 'orders'> & {
   orders?: {
     orderNo: string;
-    orderDate: number;
+    orderDate: number[];
     orderStatus: string;
     items: number;
     buyer: { attributes: Attribute[] };

diff --git a/src/app/core/models/cost-center/cost-center.mapper.spec.ts b/src/app/core/models/cost-center/cost-center.mapper.spec.ts
@@ -10,15 +10,15 @@ describe('Cost Center Mapper', () => {
           {
             orderNo: '1',
             items: 2,
-            orderDate: 1234,
+            orderDate: [2024, 1, 10],
             buyer: { attributes: [{ name: 'firstName', value: 'John' }] },
             orderTotalGross: { currency: 'USD', value: 1000.23 },
             orderTotalNet: { currency: 'USD', value: 800.87 },
           },
           {
             orderNo: '2',
             items: 4,
-            orderDate: 2341,
+            orderDate: [2024, 1, 10],
             buyer: { attributes: [{ name: 'firstName', value: 'Jack' }] },
             orderTotalGross: { currency: 'USD', value: 1000.23 },
             orderTotalNet: { currency: 'USD', value: 800.87 },

diff --git a/src/app/core/models/cost-center/cost-center.mapper.ts b/src/app/core/models/cost-center/cost-center.mapper.ts
@@ -9,7 +9,7 @@ export class CostCenterMapper {
         orders: data.orders?.map(order => ({
           documentNo: order.orderNo,
           status: order.orderStatus,
-          creationDate: order.orderDate,
+          creationDate: order.orderDate.toString(),
           attributes: order.buyer.attributes,
           totalProductQuantity: order.items,
           totals: {

diff --git a/src/app/core/models/order/order.interface.ts b/src/app/core/models/order/order.interface.ts
@@ -11,7 +11,7 @@ import { ShippingMethodData } from 'ish-core/models/shipping-method/shipping-met
 
 export interface OrderBaseData extends BasketBaseData {
   documentNumber: string;
-  creationDate: number;
+  creationDate: string;
   orderCreation: {
     status: 'COMPLETED' | 'ROLLED_BACK' | 'STOPPED' | 'CONTINUE';
     stopAction?: {

diff --git a/src/app/core/models/order/order.mapper.spec.ts b/src/app/core/models/order/order.mapper.spec.ts
@@ -8,7 +8,7 @@ import { OrderMapper } from './order.mapper';
 describe('Order Mapper', () => {
   const orderBaseData = {
     documentNumber: '4711',
-    creationDate: 0,
+    creationDate: '2024-01-26T09:52:16Z',
     status: 'New',
     statusCode: 'NEW',
     id: 'order_1234',

diff --git a/src/app/core/models/order/order.model.ts b/src/app/core/models/order/order.model.ts
@@ -11,7 +11,7 @@ type OrderBasket = Omit<AbstractBasket<OrderLineItem>, 'approval'>;
 
 export interface Order extends OrderBasket {
   documentNo: string;
-  creationDate: number;
+  creationDate: string;
   orderCreation: {
     status: 'COMPLETED' | 'ROLLED_BACK' | 'STOPPED' | 'CONTINUE';
     stopAction?: {

diff --git a/src/app/extensions/order-templates/models/order-template/order-template.interface.ts b/src/app/extensions/order-templates/models/order-template/order-template.interface.ts
@@ -7,5 +7,5 @@ export interface OrderTemplateData extends OrderTemplateHeader {
   itemsCount?: number;
   name?: string;
   uri?: string;
-  creationDate?: Date;
+  creationDate?: number;
 }
diff --git a/src/app/extensions/order-templates/models/order-template/order-template.model.ts b/src/app/extensions/order-templates/models/order-template/order-template.model.ts
@@ -6,7 +6,7 @@ export interface OrderTemplate extends OrderTemplateHeader {
   id: string;
   items?: OrderTemplateItem[];
   itemsCount?: number;
-  creationDate?: Date;
+  creationDate?: number;
 }
 
 export interface OrderTemplateItem {