fix: use 'stepQuantitiy' instead of 'stepOrderQuantity' to fetch the …

…correct data in product listings (#1432) * 'stepOrderQuantity' replaced with 'stepQuantitiy' * product detail still only returns 'stepOrderQuantity' that has to be used and mapped internally * internally the PWA now uses the name 'stepQuantity' --------- Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
intershop · May 17, 2023 · bd20419 · bd20419
1 parent 6a1c272
commit bd20419
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 10 deletions.
diff --git a/src/app/core/facades/product-context.facade.spec.ts b/src/app/core/facades/product-context.facade.spec.ts
@@ -87,7 +87,7 @@ describe('Product Context Facade', () => {
         completenessLevel: ProductCompletenessLevel.Detail,
         minOrderQuantity: 10,
         maxOrderQuantity: 100,
-        stepOrderQuantity: 10,
+        stepQuantity: 10,
         available: false,
         readyForShipmentMin: 0,
         readyForShipmentMax: 2,
@@ -159,7 +159,7 @@ describe('Product Context Facade', () => {
         completenessLevel: ProductCompletenessLevel.Detail,
         minOrderQuantity: 10,
         maxOrderQuantity: 100,
-        stepOrderQuantity: 10,
+        stepQuantity: 10,
         available: true,
         readyForShipmentMin: 0,
         readyForShipmentMax: 2,
@@ -768,7 +768,7 @@ describe('Product Context Facade', () => {
         completenessLevel: ProductCompletenessLevel.Detail,
         minOrderQuantity: 10,
         maxOrderQuantity: 100,
-        stepOrderQuantity: 10,
+        stepQuantity: 10,
         available: true,
         readyForShipmentMin: 0,
         readyForShipmentMax: 2,

diff --git a/src/app/core/facades/product-context.facade.ts b/src/app/core/facades/product-context.facade.ts
@@ -207,7 +207,7 @@ export class ProductContextFacade extends RxState<ProductContext> implements OnD
     this.connect(
       'stepQuantity',
       this.select('product').pipe(
-        map(product => product?.stepOrderQuantity || 1),
+        map(product => product?.stepQuantity || 1),
         distinctUntilChanged()
       )
     );

diff --git a/src/app/core/models/product/__snapshots__/product.mapper.spec.ts.snap b/src/app/core/models/product/__snapshots__/product.mapper.spec.ts.snap
@@ -51,7 +51,7 @@ exports[`Product Mapper fromStubData should construct a stub when supplied with
   "roundedAverageRating": 0,
   "shortDescription": "EasyShare M552, 14MP, 6.858 cm (2.7 ") LCD, 4x, 28mm, HD 720p, Black",
   "sku": "7912057",
-  "stepOrderQuantity": undefined,
+  "stepQuantity": undefined,
   "type": "Product",
 }
 `;
diff --git a/src/app/core/models/product/product.interface.ts b/src/app/core/models/product/product.interface.ts
@@ -38,7 +38,8 @@ export interface ProductData {
   productMasterSKU?: string;
   minOrderQuantity: number;
   maxOrderQuantity?: number;
-  stepOrderQuantity?: number;
+  stepOrderQuantity?: number; // property name used by the product detail response (will be deprecated)
+  stepQuantity?: number; // property name used in product list response (will become the consistent name)
   packingUnit: string;
 
   variationAttributeValuesExtended?: VariationAttributeData[];

diff --git a/src/app/core/models/product/product.mapper.ts b/src/app/core/models/product/product.mapper.ts
@@ -135,7 +135,7 @@ export class ProductMapper {
       longDescription: undefined,
       minOrderQuantity: retrieveStubAttributeValue<{ value: number }>(data, 'minOrderQuantity')?.value,
       maxOrderQuantity: retrieveStubAttributeValue<{ value: number }>(data, 'maxOrderQuantity')?.value,
-      stepOrderQuantity: retrieveStubAttributeValue<{ value: number }>(data, 'stepOrderQuantity')?.value,
+      stepQuantity: retrieveStubAttributeValue<{ value: number }>(data, 'stepQuantity')?.value,
       packingUnit: retrieveStubAttributeValue(data, 'packingUnit'),
       attributeGroups: data.attributeGroup && mapAttributeGroups(data),
       readyForShipmentMin: undefined,
@@ -161,7 +161,7 @@ export class ProductMapper {
       available: this.calculateAvailable(data.availability, data.inStock),
       minOrderQuantity: data.minOrderQuantity,
       maxOrderQuantity: data.maxOrderQuantity,
-      stepOrderQuantity: data.stepOrderQuantity,
+      stepQuantity: data.stepOrderQuantity,
       packingUnit: data.packingUnit,
       availableStock: data.availableStock,
       attributes: data.attributeGroups?.PRODUCT_DETAIL_ATTRIBUTES?.attributes || data.attributes || [],

diff --git a/src/app/core/models/product/product.model.ts b/src/app/core/models/product/product.model.ts
@@ -13,7 +13,7 @@ export interface Product {
   availableStock?: number;
   minOrderQuantity: number;
   maxOrderQuantity: number;
-  stepOrderQuantity: number;
+  stepQuantity: number;
   attributes: Attribute[];
   attributeGroups?: { [id: string]: AttributeGroup };
   attachments?: Attachment[];

diff --git a/src/app/core/services/products/products-list-attributes.ts b/src/app/core/services/products/products-list-attributes.ts
@@ -1 +1 @@
-export default 'sku,availability,manufacturer,image,minOrderQuantity,maxOrderQuantity,stepOrderQuantity,inStock,promotions,packingUnit,mastered,productMaster,productMasterSKU,roundedAverageRating,retailSet,defaultCategory';
+export default 'sku,availability,manufacturer,image,minOrderQuantity,maxOrderQuantity,stepQuantity,inStock,promotions,packingUnit,mastered,productMaster,productMasterSKU,roundedAverageRating,retailSet,defaultCategory';