fix: use 'stepQauntitiy' instead of 'stepOrderQuantity' to fetch the correct data in product listings #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roduct detail REST API calls * product detail still only returns 'stepOrderQuantity' that has to be used and mapped internally * internally the PWA now uses the name 'stepQuantity'
shauke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
The current ICM product detail REST API returns
stepOrderQuantityinformation.For that reason the product list calls where asked for
stepOrderQuantityas well but did not return that information.For product list calls only the better name
stepQuantityworks and returns the expected information.What Is the New Behavior?
The PWA now consistently uses the name
stepQuantity.Only for the product details call the mapper maps the
stepOrderQuantityvalue tostepQuantity.This way step quantity now works in product listings as well as on the product details page.
In the future the ICM product details REST API will provide the information as
stepQuantityas well and thestepOrderQuantitywill be deprecated. Once this is the case another adaption in the PWA will become necessary.Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#86081