test: allow any description for jest.each

intershop · Feb 19, 2020 · eff9d58 · eff9d58
1 parent 74c53c8
commit eff9d58
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 12 deletions.
diff --git a/tslint-rules/dist/meaningfulNamingInTestsRule.js b/tslint-rules/dist/meaningfulNamingInTestsRule.js
@@ -58,11 +58,13 @@ var Rule = (function (_super) {
                     if (description.indexOf('${') >= 0) {
                         description = descriptionToken.parent.getText();
                     }
-                    if (DESCRIPTION_VIEWPOINT_ERROR_REGEX.test(description)) {
-                        ctx.addFailureAtNode(descriptionToken, "describe what the component is doing, not what the test is doing (found \"" + description + "\")");
-                    }
-                    else if (!DESCRIPTION_REGEX.test(description)) {
-                        ctx.addFailureAtNode(descriptionToken, "\"" + description + "\" does not match " + DESCRIPTION_REGEX);
+                    if (description !== 'each') {
+                        if (DESCRIPTION_VIEWPOINT_ERROR_REGEX.test(description)) {
+                            ctx.addFailureAtNode(descriptionToken, "describe what the component is doing, not what the test is doing (found \"" + description + "\")");
+                        }
+                        else if (!DESCRIPTION_REGEX.test(description)) {
+                            ctx.addFailureAtNode(descriptionToken, "\"" + description + "\" does not match " + DESCRIPTION_REGEX);
+                        }
                     }
                 }
                 else {

diff --git a/tslint-rules/src/meaningfulNamingInTestsRule.ts b/tslint-rules/src/meaningfulNamingInTestsRule.ts
@@ -51,13 +51,16 @@ export class Rule extends Lint.Rules.AbstractRule {
           if (description.indexOf('${') >= 0) {
             description = descriptionToken.parent.getText();
           }
-          if (DESCRIPTION_VIEWPOINT_ERROR_REGEX.test(description)) {
-            ctx.addFailureAtNode(
-              descriptionToken,
-              `describe what the component is doing, not what the test is doing (found "${description}")`
-            );
-          } else if (!DESCRIPTION_REGEX.test(description)) {
-            ctx.addFailureAtNode(descriptionToken, `"${description}" does not match ${DESCRIPTION_REGEX}`);
+          // allow everything for jest.each
+          if (description !== 'each') {
+            if (DESCRIPTION_VIEWPOINT_ERROR_REGEX.test(description)) {
+              ctx.addFailureAtNode(
+                descriptionToken,
+                `describe what the component is doing, not what the test is doing (found "${description}")`
+              );
+            } else if (!DESCRIPTION_REGEX.test(description)) {
+              ctx.addFailureAtNode(descriptionToken, `"${description}" does not match ${DESCRIPTION_REGEX}`);
+            }
           }
         } else {
           ctx.addFailureAtNode(node, 'could not find a valid description');