Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reviews are visible on product master variation page #1193

Closed
M-Behr opened this issue Jun 23, 2022 · 0 comments · Fixed by #1186
Closed

Reviews are visible on product master variation page #1193

M-Behr opened this issue Jun 23, 2022 · 0 comments · Fixed by #1186
Assignees
@SGrueber
Labels
bug Something isn't working

Comments

@M-Behr
Copy link

M-Behr commented Jun 23, 2022 •
edited by azure-boards bot
Loading

Actual Behavior

Currently reviews are displayed on a product variation master page. This makes no sense because you can't buy a variation master and it should not be possible to create/display a review for that.

Expected Behavior

It should not be possible to create/display a review for a variation master product. See behavior of Responsive Starter Store.

Steps to Reproduce the Bug

Steps to reproduce the behavior:

  1. Go to product detail page of 'Microsoft Surface Book 2'
  2. See review section

Environment Details

  • Desktop: *

    • Browser: Chrome
    • Project Code Version: 2.4

Additional Context, like Screenshots, Log File Snippets etc.
image

Responsive Starter Store - no review section:
image
Note: The star rating is visible here, but I think this is a bug in the Responsive Starter Store.

AB#77640
@M-Behr M-Behr added the bug Something isn't working label Jun 23, 2022
@SGrueber SGrueber mentioned this issue Jun 29, 2022
Merged
SGrueber added a commit that referenced this issue Jun 29, 2022
@SGrueber
fix: don't display the review tab on product master variation page (#…
8f61e29 
…1193)
SGrueber added a commit that referenced this issue Jun 29, 2022
@SGrueber
fix: don't display the review tab on product master variation page (#…
ceb3bb0 
…1193)
SGrueber added a commit that referenced this issue Jul 1, 2022
@SGrueber
fix: don't display the review tab on product master variation page (#…
50f4e1e 
…1193)
SGrueber added a commit that referenced this issue Jul 1, 2022
@SGrueber
fix: don't display the review tab on product master variation page (#…
e7dff0b 
…1193)
SGrueber added a commit that referenced this issue Jul 5, 2022
@SGrueber
fix: don't display the review tab on product master variation page (#…
c70b0ff 
…1193)
shauke pushed a commit that referenced this issue Jul 13, 2022
@SGrueber @shauke
fix: don't display the review tab on product master variation page (#…
8a0a265 
…1193)

(cherry picked from commit c70b0ff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SGrueber SGrueber

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: create a product review intershop/intershop-pwa
2 participants
@SGrueber @M-Behr