Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Dynamic Branding #49

Closed
rkarl-ish opened this issue Dec 11, 2019 · 3 comments
Closed

[FR] Dynamic Branding #49

rkarl-ish opened this issue Dec 11, 2019 · 3 comments
Assignees
Labels
enhancement Enhancement to an existing feature
Milestone

Comments

@rkarl-ish
Copy link
Contributor

rkarl-ish commented Dec 11, 2019

It should be possible to dynamically change the branding within one PWA instance, e.g. exchange logo and color scheme. Dynamically, meaning no separate deployments are needed for the different brandings. This should be handled by on deployed PWA that can be configured (similar to the feature toggles) to use one or another branding.

Possible solution

Other ideas are welcome.

@rkarl-ish rkarl-ish added the enhancement Enhancement to an existing feature label Dec 11, 2019
@rkarl-ish rkarl-ish self-assigned this Dec 11, 2019
@Sebastian-Haehnlein Sebastian-Haehnlein self-assigned this Dec 11, 2019
@shauke
Copy link
Collaborator

shauke commented Jan 14, 2020

The pull request is an adaption of the multiple themes support idea from https://medium.com/better-programming/angular-multiple-themes-without-killing-bundle-size-with-material-or-not-5a80849b6b34

@shauke shauke added this to the 0.17 milestone Jan 14, 2020
shauke pushed a commit that referenced this issue Jan 16, 2020
…ion of an alternative blue theme (#49, #64)

- rename the styling root 'theme' folder to 'styles'
shauke pushed a commit that referenced this issue Jan 16, 2020
…#49, #64)

- made html structure of the 3 different headers similar for consistent logo styling

closes #49
shauke pushed a commit that referenced this issue Jan 17, 2020
…ion of an alternative blue theme (#49, #64)

- rename the styling root 'theme' folder to 'styles'
@shauke shauke closed this as completed in a5f49fb Jan 17, 2020
@liquid-tadan
Copy link
Contributor

is the documentation for this new feature available somewhere?

@dhhyi
Copy link
Collaborator

dhhyi commented Jan 31, 2020

is the documentation for this new feature available somewhere?

@liquid-tadan Not in its entirety. We have documented the usage as part of our customization guide here.

As a practical example, the current code provides two themes (under src/styles/themes), a default and a blue one. We are using it for providing a different style for the inTRONICS B2C and B2B storefront which you can change in between with a button in the header of our public deployment.

More documentation will probably follow soon, as we are currently reorganizing our documentation structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

5 participants