Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special Characters in email-address lead to problems with server communication when only encoded once #939

Closed
DiverDori opened this issue Dec 1, 2021 · 0 comments · Fixed by #940
Closed

Special Characters in email-address lead to problems with server communication when only encoded once #939

DiverDori opened this issue Dec 1, 2021 · 0 comments · Fixed by #940
Labels
bug Something isn't working
Milestone
3.0

Comments

@DiverDori
Copy link
Collaborator

DiverDori commented Dec 1, 2021 •
edited by shauke
Loading

Actual Behavior
When a registered b2b user with special characters in email address, like diver+dori@<someEmailProvider>.com tries to use the PWA, there are problems in the server communication.

Expected Behavior
Everything should work.

Steps to Reproduce the Bug

  1. Try to somehow register a user with special character, this can also happen by changing the email address of an existing user
  2. surf in the personal section with this user in the PWA
  3. --> a lot of 4xx in server communication / a lot of missing data

Environment Details
any environment

Additional Context, like Screenshots, Log File Snippets etc.

There are ICM server side fixes in 7.10.38 and 7.10.26.

AB#71772
@DiverDori DiverDori added the bug Something isn't working label Dec 1, 2021
@DiverDori DiverDori mentioned this issue Dec 1, 2021
Merged
@shauke shauke modified the milestones: 1.4, 2.0 Dec 1, 2021
@shauke shauke modified the milestones: 2.0, 3.0 Jan 31, 2022
shauke pushed a commit that referenced this issue Jul 19, 2022
@DiverDori
fix: use double encoded resource ids to support special characters in…
2e8f7e4 
… email address as user login (#939, #940)

BREAKING CHANGES:  Introduced double encoding of resource ids in REST API calls for user login (see [Migrations / 2.4 to 3.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#2.4-to-30) for more details).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

fix: use double encoded resource ids for user login intershop/intershop-pwa
2 participants
@shauke @DiverDori