Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove deferLoad and use loading lazy #1097

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Mar 30, 2022

PR Type

[x] Application / infrastructure changes

What Is the Current Behavior?

What Is the New Behavior?

Library removed and use loading="lazy" on images and iframes.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#75604

@dhhyi dhhyi added dependencies Pull requests that update a dependency file community Community contributions labels Mar 30, 2022
@dhhyi dhhyi marked this pull request as draft March 30, 2022 18:33
@dhhyi dhhyi force-pushed the deps/import-defer-load branch from bc689fa to 6ee0595 Compare March 30, 2022 19:18
@dhhyi dhhyi changed the title deps: import unmaintained directive for defer load deps: remove deferLoad and use loading lazy Mar 30, 2022
@dhhyi dhhyi requested a review from shauke March 30, 2022 19:23
@dhhyi dhhyi force-pushed the deps/import-defer-load branch 2 times, most recently from 3c7cf75 to 4bc8a2c Compare March 30, 2022 20:02
@dhhyi dhhyi marked this pull request as ready for review March 30, 2022 20:42
@shauke shauke self-assigned this Mar 31, 2022
@dhhyi dhhyi force-pushed the deps/import-defer-load branch from 4bc8a2c to 48e0627 Compare April 17, 2022 20:19
@dhhyi dhhyi force-pushed the deps/import-defer-load branch from 48e0627 to 277645e Compare April 21, 2022 14:19
@shauke shauke added this to the 3.0 milestone May 2, 2022
shauke pushed a commit that referenced this pull request May 2, 2022
BREAKING CHANGES: Removed `(deferLoad)` directive and replaced it with `loading="lazy"` (see [Migrations / 2.? to 3.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#2?-to-30) for more details).
@shauke shauke force-pushed the deps/import-defer-load branch from 277645e to 54749c8 Compare May 2, 2022 16:46
BREAKING CHANGES: Removed `(deferLoad)` directive and replaced it with `loading="lazy"` (see [Migrations / 2.4 to 3.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#24-to-30) for more details).
@shauke shauke force-pushed the deps/import-defer-load branch from 54749c8 to d1548be Compare June 27, 2022 11:16
@shauke shauke merged commit 8c74111 into develop Jun 27, 2022
@shauke shauke deleted the deps/import-defer-load branch June 27, 2022 14:16
@shauke shauke mentioned this pull request Jul 18, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contributions dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants