Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA URL Rewriting #110

Merged
merged 9 commits into from
Mar 2, 2020
Merged

PWA URL Rewriting #110

merged 9 commits into from
Mar 2, 2020

Commits on Feb 28, 2020

  1. refactor: safety return for defaultVariation()

    @dhhyi
    dhhyi committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    65e2d7e View commit details
    Browse the repository at this point in the history

  2. refactor: rename AppNotFoundRoutingModule to AppLastRoutingModule

    @dhhyi
    dhhyi committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    b0dd058 View commit details
    Browse the repository at this point in the history

  3. feat: add url property to RouteNavigation 

    - cleanup unused parameters of constructors in tests
- safety checks
    @dhhyi
    dhhyi committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    1cde2cc View commit details
    Browse the repository at this point in the history

  4. feat: SEO friendly localized URLs for product detail pages (#110) 

    - moved ProductRoutePipe to core/routing/product
- match incoming URLs for products with Angular UrlMatcher and RegExp pattern
- improved typing of ProductRoutePipe
    @dhhyi
    dhhyi committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    275acbf View commit details
    Browse the repository at this point in the history

  5. feat: SEO friendly localized URLs for category and product list pages (… 

    …#110)

- moved CategoryRoutePipe to core/routing/category
- match incoming URLs for categories with Angular UrlMatcher and RegExp pattern
- improved typing of CategoryRoutePipe
    @dhhyi
    dhhyi committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    3a77a1e View commit details
    Browse the repository at this point in the history

  6. test: adapt cypress tests for new URL patterns

    @dhhyi
    dhhyi committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    404e052 View commit details
    Browse the repository at this point in the history

  7. fix: respect selected category when switching variations on product d… 

    …etail page
    @dhhyi
    dhhyi committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    ccfc51e View commit details
    Browse the repository at this point in the history

  8. refactor: all related view entities return ProductViews instead of Pr… 

    …oducts
    @dhhyi
    dhhyi committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    ecaf2c5 View commit details
    Browse the repository at this point in the history

  9. refactor: return new links in link-parser

    @dhhyi
    dhhyi committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    0ae596f View commit details
    Browse the repository at this point in the history