feat: display maintenance page in case of a 503 http status error #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
added
feature
shauke
requested changes
Sep 1, 2022
jometzner
force-pushed
the
feature/maintenance_page
branch
from
e213e17
to
d1d1e0c
Compare
SGrueber
force-pushed
the
feature/maintenance_page
branch
2 times, most recently
from
f56b1d7
to
6521494
Compare
shauke
requested changes
Sep 6, 2022
SGrueber
force-pushed
the
feature/maintenance_page
branch
from
09f0073
to
11cf6d2
Compare
jometzner
reviewed
Sep 9, 2022
SGrueber
force-pushed
the
feature/maintenance_page
branch
2 times, most recently
from
ca38670
to
2b0d323
Compare
jometzner
previously approved these changes
Sep 12, 2022
Closed
shauke
previously approved these changes
Sep 22, 2022
shauke
requested review from
martinstockmann
and removed request for
mglatter
* current difference to the simple header: logo link with reloading link instead of router link
shauke
pushed a commit
that referenced
this pull request
Sep 22, 2022
* display maintenance page only if the error still exists otherwise route to the home page * requires WebAdapter version 1.1.4 (ICM 7.10.38.16-LTS?)
shauke
force-pushed
the
feature/maintenance_page
branch
from
2b0d323
to
38159a7
Compare
shauke
previously approved these changes
Sep 22, 2022
* display maintenance page only if the error still exists otherwise route to the home page * requires ICM 7.10.38.16-LTS (WebAdapter version 1.1.4)
shauke
force-pushed
the
feature/maintenance_page
branch
from
38159a7
to
b457720
Compare
shauke
pushed a commit
that referenced
this pull request
Sep 23, 2022
* display maintenance page only if the error still exists otherwise route to the home page * requires ICM 7.10.38.16-LTS (WebAdapter version 1.1.4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the Current Behavior?
If the ICM server is in maintenance mode REST requests respond with an 503 http status code, but the client doesn`t handle these errors properly.
What Is the New Behavior?
The PWA shows a maintenance page if a REST request respond with a 503 error.
Does this PR Introduce a Breaking Change?
[x] No
Requirements
AB#75906