fix: cookie page guard should only use NgModal on browser #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxKless
approved these changes
May 5, 2022
shauke
pushed a commit
that referenced
this pull request
May 5, 2022
* cookie page guard should only use NgModal on browser side * ssr returns loading page on entering the `/cookie` route
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
In a ssr+nginx setup the route: /cookies will show the error page of the nginx. The ssr container have the following log:
The cookie page guard should manage to open and close a modal to select the desired cookies. It should be clear, that modals are only available on browser and not on server side. (angular-slider/ngx-slider#66)
Issue Number: Closes #
What Is the New Behavior?
The cookie page guard manages the cookie modal only on browser side.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
Reproduce: Go to demo page: https://intershoppwa.azurewebsites.net/cookies
AB#76445