-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pagespeed module from our nginx container #1150
Conversation
@jometzner That was one of the first major deployment improvements when we initially set up the demo servers. And at the beginning it also yielded a highscore in performance. Of course a lot has changes since then and due to the added PWA complexity (and maintenance status recently shown by the pinning of a 2yo ubuntu base image) it might not be useful anymore. I like the refactoring of using built-in nginx startup scripts. 👍 This might be the way to go for a maintainable PWA, still, I'm sad to see it go away 😭 |
Well the module is not gone yet. We're re-evaluating the decision from the first days to see if it still fits the requirements. I can still remember that it did good on the page speed results. |
36de4db
to
4ba5ea3
Compare
4ba5ea3
to
7f6042a
Compare
First local tests did not show any changes in the lighthouse performance results. |
You could give the pull request a thumbs up |
I'll write some documentation for this change before it gets merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested in our project yet, will do that next.
fab039e
to
c12db4b
Compare
12bf1e4
to
a45edb0
Compare
✅ |
b7fd85a
to
f775160
Compare
PR Type
[ ] Bugfix
[ X ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Currently we use all sorts of filters included in the pagespeed module of NGINX. The contribution to actual page speed ranking is not 100% clear. Especially since the introduction of core web vitals it would be beneficial to re-evaluate the usage of this module.
Con List:
What Is the New Behavior?
Does this PR Introduce a Breaking Change?
[ X ] Yes
[ ] No
Other Information
AB#76451