Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use new token api service #1156

Merged
merged 2 commits into from
Dec 22, 2022
Merged

feat: use new token api service #1156

merged 2 commits into from
Dec 22, 2022

Conversation

Eisie96
Copy link
Contributor

@Eisie96 Eisie96 commented May 10, 2022 •
edited by shauke
Loading

PR Type

[x] Feature
[x] Documentation content changes

What Is the Current Behavior?

The old token behavior with the token exchange for each request, should be replaced by the new token api service.

What Is the New Behavior?

The new token service should be used to authenticate a user. In case the user doesn't login to the PWA, the apiToken for an anonymous user should be used. The apiToken should be automatically refreshed before the token expires.

Does this PR Introduce a Breaking Change?

[x] Yes

Other Information

  • Use new token service to get tokens for an anonymous user
  • Use new token service to get tokens for a user with credentials
  • Restore all necessary store informations on reload
  • Refresh before it is expired

AB#76575

@Eisie96 Eisie96 changed the title Feat/token service feat/use new token api service May 10, 2022
@Eisie96 Eisie96 changed the title feat/use new token api service feat: use new token api service May 10, 2022
@Eisie96 Eisie96 force-pushed the feat/token-service branch 2 times, most recently from fd9fbfc to 6756283 Compare June 9, 2022 11:50
@SGrueber SGrueber added this to the 3.0 milestone Jul 6, 2022
@Eisie96 Eisie96 marked this pull request as ready for review July 19, 2022 13:32
@shauke shauke requested review from shauke and MaxKless and removed request for shauke July 20, 2022 14:10
@MaxKless MaxKless requested a review from jometzner July 25, 2022 08:20
@SGrueber SGrueber self-requested a review July 26, 2022 14:17
SGrueber
SGrueber requested changes Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@SGrueber SGrueber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migration note is missing

SGrueber
SGrueber requested changes Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@SGrueber SGrueber left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xxx

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Azure Demo Servers are available:

@Eisie96 @shauke
feat: use ICM '/token' REST endpoint for authentication (#1156)
8078eb0 
* old token behavior with the token exchange for each request is replaced by the exchange via token API
* get tokens for an anonymous user and for a user with credentials
* refresh token before it is expired
* revoke token on logout

BREAKING CHANGES: PWA uses the ICM `/token` REST endpoint to retrieve user token, every anonymous user will get a anonymous user token, every identity provider has to configure the `oAuthService` with information about the token endpoint, before expiration the given token should be refreshed.
shauke pushed a commit that referenced this pull request Dec 19, 2022
@Eisie96 @SGrueber @shauke
docs: improve authentication documentation (#1156)
3626575 
* reworked authentication documentation structuring after implementation of `/token` API integration
* improved documentation regarding ICM authentication, SSO and Punchout

Co-authored-by: Silke <s.grueber@intershop.de>
shauke
shauke previously approved these changes Dec 19, 2022
View reviewed changes
shauke pushed a commit that referenced this pull request Dec 19, 2022
@Eisie96 @SGrueber @shauke
docs: improve authentication documentation (#1156)
6b11ad1 
* reworked authentication documentation structuring after implementation of `/token` API integration
* improved documentation regarding ICM authentication, SSO and Punchout

Co-authored-by: Silke <s.grueber@intershop.de>
shauke
shauke previously approved these changes Dec 19, 2022
View reviewed changes
@github-actions
Copy link

Azure Demo Servers are available:

@mglatter
Copy link
Contributor

Further adjustments of the other .md files may follow after having reviewed them as well.

@mglatter
Copy link
Contributor

I found some more things I could not comment on directly in the files as no changes have been made in the lines in question:

migrations.md

line 94 says: "The @ngx-translate/http-loader dependency was removed since we did not use it."
The link text says ngx-translate/http-loader but the link opens ngx-translate/core. Is this correct?

nginx-startup.md

Line 20 says: "- Connect it to the PWA with UPSTREAM_PWA in the form of http://<IP>:<PORT>"
Can you please specify and replace "it" with the concrete name of what should be connected? Else it is not clear if nginx or a Docker image is meant to be connected (at least to me not being into the topic deeply). ;-) Thanks

@shauke
Copy link
Collaborator

shauke commented Dec 21, 2022

  • I checked and the link is correct.
  • fixed the sentence and used "nginx" for "it"

@Eisie96 @SGrueber
@mglatter @shauke
docs: improve authentication documentation (#1156)
ad1e8ea 
* reworked authentication documentation structuring after implementation of `/token` API integration
* improved documentation regarding ICM authentication, SSO and Punchout

Co-authored-by: Silke <s.grueber@intershop.de>
Co-authored-by: MGlatter <m.glatter@intershop.de>
@shauke shauke dismissed SGrueber’s stale review December 22, 2022 08:36

everything was changed

@shauke shauke added the feature New feature or request label Dec 22, 2022
@Eisie96 Eisie96 merged commit cf89956 into develop Dec 22, 2022
@Eisie96 Eisie96 deleted the feat/token-service branch December 22, 2022 08:41
Eisie96 added a commit that referenced this pull request Dec 22, 2022
@Eisie96
feat: use ICM '/token' REST endpoint for authentication (#1156)
4e02efd 
* old token behavior with the token exchange for each request is replaced by the exchange via token API
* get tokens for an anonymous user and for a user with credentials
* refresh token before it is expired
* revoke token on logout

BREAKING CHANGES: PWA uses the ICM `/token` REST endpoint to retrieve user token, every anonymous user will get a anonymous user token, every identity provider has to configure the `oAuthService` with information about the token endpoint, before expiration the given token should be refreshed.
@SGrueber SGrueber mentioned this pull request Jan 16, 2023
Merged
@Eisie96 Eisie96 mentioned this pull request Apr 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxKless MaxKless MaxKless left review comments

@jometzner jometzner jometzner left review comments

@shauke shauke shauke approved these changes

@SGrueber SGrueber SGrueber left review comments

Assignees

@jometzner jometzner

@Eisie96 Eisie96

Labels
feature New feature or request
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@Eisie96 @jometzner @mglatter @shauke @MaxKless @SGrueber