-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(seo): optimized content page URLs with full content page path #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisie96
force-pushed
the
refactor/improve-content-pages-url
branch
from
May 19, 2022 11:44
2607187
to
24e466e
Compare
shauke
requested changes
May 30, 2022
Eisie96
force-pushed
the
refactor/improve-content-pages-url
branch
from
June 2, 2022 08:57
7fbaf20
to
72215de
Compare
Eisie96
force-pushed
the
refactor/improve-content-pages-url
branch
2 times, most recently
from
June 2, 2022 09:16
52f0927
to
b59ba18
Compare
shauke
force-pushed
the
refactor/improve-product-url
branch
from
June 15, 2022 11:04
13c082d
to
2201c44
Compare
shauke
force-pushed
the
refactor/improve-content-pages-url
branch
2 times, most recently
from
June 15, 2022 12:38
6992ea1
to
8b04f31
Compare
shauke
force-pushed
the
refactor/improve-product-url
branch
2 times, most recently
from
June 15, 2022 19:42
32b9629
to
b3ebaa7
Compare
shauke
pushed a commit
that referenced
this pull request
Jun 15, 2022
…1161) * introduced content page route generation similar to categoryies * added content page id marker 'pg'
shauke
force-pushed
the
refactor/improve-content-pages-url
branch
from
June 15, 2022 19:43
8b04f31
to
37dd363
Compare
shauke
changed the title
refactor: use an url matcher to define right path for content pages
feat(seo): optimized content page URLs with full content page path
Jun 15, 2022
shauke
force-pushed
the
refactor/improve-product-url
branch
from
June 15, 2022 20:12
b3ebaa7
to
4d13b14
Compare
shauke
pushed a commit
that referenced
this pull request
Jun 15, 2022
…1161) * introduced content page route generation similar to categoryies * added content page id marker 'pg' BREAKING CHANGES: Changed content page routes/URLs (see [Migrations / 2.4 to 3.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#24-to-30) for more details).
shauke
force-pushed
the
refactor/improve-content-pages-url
branch
from
June 15, 2022 20:27
37dd363
to
7caa68f
Compare
mglatter
previously approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.md files reviewed and changes made in PR directly (see commits)
shauke
force-pushed
the
refactor/improve-content-pages-url
branch
from
July 18, 2022 18:32
63eff5c
to
8a62efc
Compare
shauke
force-pushed
the
refactor/improve-product-url
branch
from
July 19, 2022 14:59
4d13b14
to
806b166
Compare
…1161) * introduced content page route generation similar to categoryies * added content page id marker 'pg' BREAKING CHANGES: Changed content page routes/URLs (see [Migrations / 2.4 to 3.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#24-to-30) for more details).
shauke
force-pushed
the
refactor/improve-content-pages-url
branch
from
July 19, 2022 15:21
8a62efc
to
ff75ee0
Compare
shauke
approved these changes
Jul 19, 2022
shauke
pushed a commit
that referenced
this pull request
Jul 19, 2022
…1161) * introduced content page route generation similar to categoryies * added content page id marker 'pg' BREAKING CHANGES: Changed content page routes/URLs (see [Migrations / 2.4 to 3.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#24-to-30) for more details).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ x ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
The content page url is defined as a non customizable, fixed url pattern.
Issue Number: Closes #
What Is the New Behavior?
The content page url should be detected by a customizable matcher.
Does this PR Introduce a Breaking Change?
[ ] Yes
[ x ] No
Other Information
AB#76628