Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(seo): optimized content page URLs with full content page path #1161

Merged
merged 3 commits into from
Jul 19, 2022

Conversation

Eisie96
Copy link
Contributor

@Eisie96 Eisie96 commented May 12, 2022

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ x ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

The content page url is defined as a non customizable, fixed url pattern.

Issue Number: Closes #

What Is the New Behavior?

The content page url should be detected by a customizable matcher.

Does this PR Introduce a Breaking Change?

[ ] Yes
[ x ] No

Other Information

AB#76628

@Eisie96 Eisie96 force-pushed the refactor/improve-content-pages-url branch from 2607187 to 24e466e Compare May 19, 2022 11:44
src/app/pages/content/content-page.module.ts Outdated Show resolved Hide resolved
src/app/core/routing/content-page/content-page.route.ts Outdated Show resolved Hide resolved
src/app/core/routing/content-page/content-page.route.ts Outdated Show resolved Hide resolved
@shauke shauke added this to the 3.0 milestone May 31, 2022
@Eisie96 Eisie96 force-pushed the refactor/improve-content-pages-url branch from 7fbaf20 to 72215de Compare June 2, 2022 08:57
@Eisie96 Eisie96 marked this pull request as ready for review June 2, 2022 08:58
@Eisie96 Eisie96 force-pushed the refactor/improve-content-pages-url branch 2 times, most recently from 52f0927 to b59ba18 Compare June 2, 2022 09:16
@MaxKless MaxKless changed the base branch from develop to refactor/improve-product-url June 7, 2022 13:28
@MaxKless MaxKless requested a review from mglatter June 7, 2022 15:07
@shauke shauke force-pushed the refactor/improve-product-url branch from 13c082d to 2201c44 Compare June 15, 2022 11:04
@shauke shauke force-pushed the refactor/improve-content-pages-url branch 2 times, most recently from 6992ea1 to 8b04f31 Compare June 15, 2022 12:38
@shauke shauke force-pushed the refactor/improve-product-url branch 2 times, most recently from 32b9629 to b3ebaa7 Compare June 15, 2022 19:42
shauke pushed a commit that referenced this pull request Jun 15, 2022
…1161)

* introduced content page route generation similar to categoryies
* added content page id marker 'pg'
@shauke shauke force-pushed the refactor/improve-content-pages-url branch from 8b04f31 to 37dd363 Compare June 15, 2022 19:43
@shauke shauke changed the title refactor: use an url matcher to define right path for content pages feat(seo): optimized content page URLs with full content page path Jun 15, 2022
@shauke shauke force-pushed the refactor/improve-product-url branch from b3ebaa7 to 4d13b14 Compare June 15, 2022 20:12
shauke pushed a commit that referenced this pull request Jun 15, 2022
…1161)

* introduced content page route generation similar to categoryies
* added content page id marker 'pg'

BREAKING CHANGES: Changed content page routes/URLs (see [Migrations / 2.4 to 3.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#24-to-30) for more details).
@shauke shauke force-pushed the refactor/improve-content-pages-url branch from 37dd363 to 7caa68f Compare June 15, 2022 20:27
mglatter
mglatter previously approved these changes Jun 28, 2022
Copy link
Contributor

@mglatter mglatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.md files reviewed and changes made in PR directly (see commits)

@shauke shauke force-pushed the refactor/improve-content-pages-url branch from 63eff5c to 8a62efc Compare July 18, 2022 18:32
@shauke shauke force-pushed the refactor/improve-product-url branch from 4d13b14 to 806b166 Compare July 19, 2022 14:59
Base automatically changed from refactor/improve-product-url to develop July 19, 2022 15:01
…1161)

* introduced content page route generation similar to categoryies
* added content page id marker 'pg'

BREAKING CHANGES: Changed content page routes/URLs (see [Migrations / 2.4 to 3.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#24-to-30) for more details).
@shauke shauke force-pushed the refactor/improve-content-pages-url branch from 8a62efc to ff75ee0 Compare July 19, 2022 15:21
@shauke shauke merged commit 46379ac into develop Jul 19, 2022
@shauke shauke deleted the refactor/improve-content-pages-url branch July 19, 2022 15:26
shauke pushed a commit that referenced this pull request Jul 19, 2022
…1161)

* introduced content page route generation similar to categoryies
* added content page id marker 'pg'

BREAKING CHANGES: Changed content page routes/URLs (see [Migrations / 2.4 to 3.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#24-to-30) for more details).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants