-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(seo): optimized product URLs with full category path #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisie96
force-pushed
the
refactor/improve-product-url
branch
2 times, most recently
from
May 25, 2022 13:15
b579095
to
f7ece38
Compare
Eisie96
force-pushed
the
refactor/improve-product-url
branch
from
May 30, 2022 07:50
ddc2fce
to
31d83a8
Compare
shauke
previously approved these changes
May 30, 2022
Eisie96
force-pushed
the
refactor/improve-product-url
branch
from
June 1, 2022 12:12
31d83a8
to
13c082d
Compare
shauke
force-pushed
the
refactor/improve-category-url
branch
from
June 15, 2022 11:02
9f9b456
to
94631e6
Compare
shauke
force-pushed
the
refactor/improve-product-url
branch
from
June 15, 2022 11:04
13c082d
to
2201c44
Compare
shauke
force-pushed
the
refactor/improve-category-url
branch
from
June 15, 2022 12:37
94631e6
to
9ea68cf
Compare
shauke
force-pushed
the
refactor/improve-product-url
branch
from
June 15, 2022 12:44
2201c44
to
32b9629
Compare
shauke
force-pushed
the
refactor/improve-category-url
branch
3 times, most recently
from
June 15, 2022 19:40
7367d1e
to
dc6f236
Compare
shauke
pushed a commit
that referenced
this pull request
Jun 15, 2022
* still including product name and variation attributes * changed product sku marker from 'sku' to 'prd'
shauke
force-pushed
the
refactor/improve-product-url
branch
from
June 15, 2022 19:42
32b9629
to
b3ebaa7
Compare
shauke
changed the title
refactor: improve product url
feat(seo): optimized product URLs with full category path
Jun 15, 2022
shauke
pushed a commit
that referenced
this pull request
Jun 15, 2022
* still including product name and variation attributes * changed product sku marker from 'sku' to 'prd' BREAKING CHANGES: Changed product routes/URLs (see [Migrations / 2.4 to 3.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#24-to-30) for more details).
shauke
force-pushed
the
refactor/improve-product-url
branch
from
June 15, 2022 20:12
b3ebaa7
to
4d13b14
Compare
shauke
force-pushed
the
refactor/improve-category-url
branch
from
June 15, 2022 20:26
dc6f236
to
bd25b16
Compare
* still including product name and variation attributes * changed product sku marker from 'sku' to 'prd' BREAKING CHANGES: Changed product routes/URLs (see [Migrations / 2.4 to 3.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#24-to-30) for more details).
shauke
force-pushed
the
refactor/improve-product-url
branch
from
July 19, 2022 14:59
4d13b14
to
806b166
Compare
shauke
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ x ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
The current product url doesn't contain the full category context. (/PCs/Acer-Predator-G3-605-sku4713147997367-catComputers.1835.153)
Issue Number: Closes #
What Is the New Behavior?
This needs to be improved for SEO. Every product page should contain the full category context. Only display-names should be used. The needed sku and categoryUniqueId to get the data from the ICM should be at the end of the url. (/computers/notebooks-and-pcs/pcs/acer-predator-g3-605-sku4713147997367-catComputers.1835.153)
Does this PR Introduce a Breaking Change?
[ x ] Yes
[ ] No
Other Information
The prerequisite of this PR is #1163
AB#76790