Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(seo): optimized product URLs with full category path #1164

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

Eisie96
Copy link
Contributor

@Eisie96 Eisie96 commented May 18, 2022

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ x ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

The current product url doesn't contain the full category context. (/PCs/Acer-Predator-G3-605-sku4713147997367-catComputers.1835.153)

Issue Number: Closes #

What Is the New Behavior?

This needs to be improved for SEO. Every product page should contain the full category context. Only display-names should be used. The needed sku and categoryUniqueId to get the data from the ICM should be at the end of the url. (/computers/notebooks-and-pcs/pcs/acer-predator-g3-605-sku4713147997367-catComputers.1835.153)

Does this PR Introduce a Breaking Change?

[ x ] Yes
[ ] No

Other Information

The prerequisite of this PR is #1163

AB#76790

@Eisie96 Eisie96 force-pushed the refactor/improve-product-url branch 2 times, most recently from b579095 to f7ece38 Compare May 25, 2022 13:15
@Eisie96 Eisie96 marked this pull request as ready for review May 30, 2022 07:05
@Eisie96 Eisie96 force-pushed the refactor/improve-product-url branch from ddc2fce to 31d83a8 Compare May 30, 2022 07:50
shauke
shauke previously approved these changes May 30, 2022
src/app/core/routing/product/product.route.ts Show resolved Hide resolved
@shauke shauke added this to the 3.0 milestone May 31, 2022
@Eisie96 Eisie96 force-pushed the refactor/improve-product-url branch from 31d83a8 to 13c082d Compare June 1, 2022 12:12
@dhhyi dhhyi changed the base branch from develop to refactor/improve-category-url June 6, 2022 10:18
@dhhyi dhhyi changed the base branch from refactor/improve-category-url to develop June 6, 2022 10:19
@MaxKless MaxKless changed the base branch from develop to refactor/improve-category-url June 7, 2022 13:21
@shauke shauke force-pushed the refactor/improve-category-url branch from 9f9b456 to 94631e6 Compare June 15, 2022 11:02
@shauke shauke force-pushed the refactor/improve-product-url branch from 13c082d to 2201c44 Compare June 15, 2022 11:04
@shauke shauke force-pushed the refactor/improve-category-url branch from 94631e6 to 9ea68cf Compare June 15, 2022 12:37
@shauke shauke force-pushed the refactor/improve-product-url branch from 2201c44 to 32b9629 Compare June 15, 2022 12:44
@shauke shauke force-pushed the refactor/improve-category-url branch 3 times, most recently from 7367d1e to dc6f236 Compare June 15, 2022 19:40
shauke pushed a commit that referenced this pull request Jun 15, 2022
* still including product name and variation attributes
* changed product sku marker from 'sku' to 'prd'
@shauke shauke force-pushed the refactor/improve-product-url branch from 32b9629 to b3ebaa7 Compare June 15, 2022 19:42
@shauke shauke changed the title refactor: improve product url feat(seo): optimized product URLs with full category path Jun 15, 2022
shauke pushed a commit that referenced this pull request Jun 15, 2022
* still including product name and variation attributes
* changed product sku marker from 'sku' to 'prd'

BREAKING CHANGES: Changed product routes/URLs (see [Migrations / 2.4 to 3.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#24-to-30) for more details).
@shauke shauke force-pushed the refactor/improve-product-url branch from b3ebaa7 to 4d13b14 Compare June 15, 2022 20:12
@shauke shauke force-pushed the refactor/improve-category-url branch from dc6f236 to bd25b16 Compare June 15, 2022 20:26
Base automatically changed from refactor/improve-category-url to develop July 19, 2022 14:54
* still including product name and variation attributes
* changed product sku marker from 'sku' to 'prd'

BREAKING CHANGES: Changed product routes/URLs (see [Migrations / 2.4 to 3.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#24-to-30) for more details).
@shauke shauke force-pushed the refactor/improve-product-url branch from 4d13b14 to 806b166 Compare July 19, 2022 14:59
@shauke shauke merged commit 0252857 into develop Jul 19, 2022
@shauke shauke deleted the refactor/improve-product-url branch July 19, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants