Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CMS managed footer #1166

Merged
merged 2 commits into from
Jul 19, 2022
Merged

feat: CMS managed footer #1166

merged 2 commits into from
Jul 19, 2022

Conversation

suschneider
Copy link
Collaborator

@suschneider suschneider commented May 19, 2022

PR Type

[x] Feature

What Is the Current Behavior?

Currently the footer content is set via a big localization variable.
Some links in the footer don't work (e.g links for categories and products).

Issue Number: Closes #1144

What Is the New Behavior?

The links in the footer can be managed via CMS.
All links in footer are useful and work.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

fixes AB#76427, AB#76300

AB#76823

@suschneider suschneider self-assigned this May 19, 2022
@suschneider suschneider added the feature New feature or request label May 19, 2022
@suschneider suschneider modified the milestones: 2.4, 3.0 May 19, 2022
@suschneider suschneider requested a review from shauke May 19, 2022 14:07
shauke
shauke previously approved these changes May 20, 2022
@shauke shauke force-pushed the feature/cms-managed-footer branch from aa79266 to 0efa025 Compare July 19, 2022 14:40
@shauke shauke merged commit 562c56a into develop Jul 19, 2022
@shauke shauke deleted the feature/cms-managed-footer branch July 19, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request has conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links for categories and products in the footer don't work
2 participants