-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Back To Top Button #1180
Merged
Merged
Add Back To Top Button #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoritzRS
added
enhancement
Enhancement to an existing feature
feature
New feature or request
labels
Jun 3, 2022
shauke
previously approved these changes
Aug 1, 2022
shauke
force-pushed
the
feature/back-to-top
branch
from
August 1, 2022 20:23
f42f7a1
to
fb8f3f8
Compare
shauke
previously approved these changes
Aug 1, 2022
iwiederhold
previously approved these changes
Aug 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it looks better with the icon button! THX.
shauke
force-pushed
the
feature/back-to-top
branch
from
August 3, 2022 08:38
b93796c
to
7a97237
Compare
shauke
previously approved these changes
Aug 3, 2022
SGrueber
force-pushed
the
feature/back-to-top
branch
from
August 11, 2022 09:43
710d4d2
to
815a99a
Compare
shauke
force-pushed
the
feature/back-to-top
branch
from
August 11, 2022 14:56
eae2eb3
to
99e9087
Compare
* adapted cypress testing to work with smooth scrolling
shauke
force-pushed
the
feature/back-to-top
branch
from
August 11, 2022 15:39
99e9087
to
3bc0587
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
PWA does not provide a back to top button.
What Is the New Behavior?
PWA provides a default back to top button
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
Implementing a back to top button is a possible repetitive task in customer projects.
AB#77233