Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Back To Top Button #1180

Merged
merged 3 commits into from
Aug 11, 2022
Merged

Add Back To Top Button #1180

merged 3 commits into from
Aug 11, 2022

Conversation

MoritzRS
Copy link
Contributor

@MoritzRS MoritzRS commented Jun 3, 2022

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

PWA does not provide a back to top button.

What Is the New Behavior?

PWA provides a default back to top button

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

Implementing a back to top button is a possible repetitive task in customer projects.

AB#77233

@MoritzRS MoritzRS added enhancement Enhancement to an existing feature feature New feature or request labels Jun 3, 2022
@shauke shauke self-assigned this Jun 8, 2022
@shauke shauke self-requested a review June 8, 2022 07:46
@shauke shauke added this to the 3.0 milestone Aug 1, 2022
shauke
shauke previously approved these changes Aug 1, 2022
shauke
shauke previously approved these changes Aug 1, 2022
iwiederhold
iwiederhold previously approved these changes Aug 3, 2022
Copy link

@iwiederhold iwiederhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it looks better with the icon button! THX.

shauke
shauke previously approved these changes Aug 3, 2022
shauke and others added 2 commits August 11, 2022 17:28
@shauke shauke merged commit 27f1f27 into develop Aug 11, 2022
@shauke shauke deleted the feature/back-to-top branch August 11, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants